[RFC] merge `viewer` app into server repository#60480

Draft

susnux wants to merge 3769 commits into

chore/merge-viewer

Contributor

susnux commented May 16, 2026 •

edited

Loading

Summary

Viewer is a force-enabled required app for quite some time, it must be installed when using Nextcloud.
To make developers life easier and to reduce duplicated assets ( 🚀 they can be shared now with other server apps) I merged the repository with the full history into the server.

TODO

Adjust more Cypress tests
Adjust ESLint issues

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

skjnldsv and others added 30 commits

August 4, 2025 07:58


          fix(workflows): ignore auto title for renovate PRs

0bdfa4e

Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>


          Merge pull request #2919 from nextcloud/renovate/migrate-config

d3b65a9


          Chore(deps): Bump tmp from 0.2.3 to 0.2.4

71c79e1

Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.3 to 0.2.4.
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.3...v0.2.4)

---
updated-dependencies:
- dependency-name: tmp
  dependency-version: 0.2.4
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>


          Merge pull request #2923 from nextcloud/dependabot/npm_and_yarn/tmp-0…

fc47aff

….2.4


          fix(l10n): Update translations from Transifex

259ddd6

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          chore(deps): update dependency typescript to ^5.9.2

0d74028


          Merge pull request #2925 from nextcloud/renovate/master-typescript

667a38a

chore(deps): update dependency typescript to ^5.9.2 (master)


          fix(l10n): Update translations from Transifex

419c160

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          fix: sorting to align with files list

488f92a

Signed-off-by: Luka Trovic <luka@nextcloud.com>


          Merge pull request #2924 from nextcloud/fix-sorting

266abf2


          fix(l10n): Update translations from Transifex

fdc7e07

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          fix(l10n): Update translations from Transifex

91eaa0e

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          fix(l10n): Update translations from Transifex

4bc5e26

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          build: update node and npm engines versions

dc79ab6

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>


          Merge pull request #2938 from nextcloud/feat/package-node-npm-engines…

7a2fd75

…-update

build: update node and npm engines versions


          fix(l10n): Update translations from Transifex

bf634d0

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          fix(l10n): Update translations from Transifex

37d909e

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          style(icon): Use material symbol, outlined variant for icons

8a81dac

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>


          Merge pull request #2941 from nextcloud/style/noid/materialSymbolOutl…

239f55b

…ined


          fix: make sure ownerId is a string even when Numeric

The ownerId is supposed to always be a string value, but if someone's
userId is a Numeric name, then file deletion breaks, because the ownerId
is taken in as Number.

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>


          Merge pull request #2942 from nextcloud/fix/wrongOwnerType

b747500


          fix: correct typo in owner-id check that casts it to string

fe00185

Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>


          Merge pull request #2946 from nextcloud/fix/wrongOwnerTypeII

26ac166


          fix: viewer files router in standalone mode

fb83139

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>


          Merge pull request #2947 from nextcloud/fix/standalone

0ed2228


          fix(l10n): Update translations from Transifex

c6e4a33

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          feat: add API package to register handlers in init scripts

4b81ab7

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          test: adjust tests after outlined-material-icons switch

481eb41

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          Merge pull request #2922 from nextcloud/feat/viewer-api

9e3293f

feat: add API package to register handlers in init scripts


          chore(deps): update dockerode

4bf6bf5

github-actions Bot and others added 11 commits

April 30, 2026 23:47


          Merge pull request #3170 from nextcloud/dependabot/github_actions/act…

51b5d5e

…ions/github-script-9.0.0

Chore(deps): Bump actions/github-script from 8.0.0 to 9.0.0


          Chore(deps): Bump peter-evans/create-pull-request from 7.0.8 to 8.1.1

7dc5d88

Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 7.0.8 to 8.1.1.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v7.0.8...5f6978f)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-version: 8.1.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>


          Merge pull request #3171 from nextcloud/dependabot/github_actions/pet…

f5e4660

…er-evans/create-pull-request-8.1.1

Chore(deps): Bump peter-evans/create-pull-request from 7.0.8 to 8.1.1


          fix(l10n): Update translations from Transifex

e8d7db6

Signed-off-by: Nextcloud bot <bot@nextcloud.com>


          Chore(deps): Bump cypress-io/github-action from 7.1.9 to 7.2.0

39dfb1c

Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 7.1.9 to 7.2.0.
- [Release notes](https://github.com/cypress-io/github-action/releases)
- [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md)
- [Commits](cypress-io/github-action@783cb3f...b7a7441)

---
updated-dependencies:
- dependency-name: cypress-io/github-action
  dependency-version: 7.2.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>


          Chore(deps): Bump actions/checkout from 6.0.0 to 6.0.2

022978d

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v6...de0fac2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>


          Merge pull request #3172 from nextcloud/dependabot/github_actions/cyp…

976ce7a

…ress-io/github-action-7.2.0

Chore(deps): Bump cypress-io/github-action from 7.1.9 to 7.2.0


          Merge pull request #3173 from nextcloud/dependabot/github_actions/act…

627be17

…ions/checkout-6.0.2

Chore(deps): Bump actions/checkout from 6.0.0 to 6.0.2


          feat(deps): Add Nextcloud 35 support on master

df6117c

Signed-off-by: Joas Schilling <coding@schilljs.com>


          Merge pull request #3182 from nextcloud/update-master-version

d4b3dec

feat(deps): Add Nextcloud 35 support on master


          chore: Merge viewer repository into server

ceeda89

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux added 2. developing performance 🚀 developer experience labels

susnux added this to the Nextcloud 35 milestone

susnux added 7 commits

May 16, 2026 16:29


          chore(viewer): merge config files with root server configs

bfb91b9

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          chore(viewer): merge AUTHORS with server authors

9e75c50

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          chore(viewer): setup build system for the viewer

43a1a28

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          fix(viewer): adjust source code to build with legacy frontend

48c13a8

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          test(cypress): merge viewer tests with server Cypress tests

6dcb1be

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          chore: adjust viewer cypress tests for ESLint code style

a05fbd7

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          test(viewer): adjust viewer Cypress tests to run with server config

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux force-pushed the chore/merge-viewer branch from 8a9e0e9 to 65b8a40 Compare

May 16, 2026 14:37

susnux added 3 commits

May 16, 2026 16:48


          chore(viewer): setup psalm and resolve issues

d2535e6

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          chore(viewer): resolve stylelint issues

4394ba2

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>


          chore: compile assets

6e00e09

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux force-pushed the chore/merge-viewer branch from 3a13166 to 6e00e09 Compare

May 16, 2026 14:48

Contributor Author

susnux commented May 16, 2026

What is you opinion on merging the Viewer into server?
From my point of view it should be done because its required (force-enabled) and shipped, so every time you clone the server repository you also need to have the viewer somewhere cloned to be able to properly run Nextcloud.
So it improves DX, reduces core Nextcloud asset size as dependencies can be shared and let us earlier informed if some cross dependencies break.

@AndyScherzinger @artonge @sorbaugh @skjnldsv

Merge with full history (as shown here) is possible and does not increase server size a lot, but before I put more effort into finish up the merge (see last 8 commits to align code bases) I would like to know if this is something we want to have or if we stick with external repository.

Target would be NC35+ and keep 34 and before in the external repository (stable branches) - that's why I ask this now directly after branch-off.

skjnldsv requested changes

View reviewed changes

Member

skjnldsv left a comment

Please wait for the new viewer API
This is in my todo, I would NOT merge the current viewer in server for now.

Contributor Author

susnux commented May 18, 2026

I would NOT merge the current viewer in server for now.

Why that? One could also adjust the API after merge, as the merge does not change much and you open changes should apply just well as the history of the repository is preserved in the merge.

The only thing why I proposed this now is to give everyone working with the server repo more time to adjust their steps - e.g. containers to not fetch the viewer anymore as its included or similar things. Meaning giving everyone a full cycle to adapt :)

So would be fine with me to just wait (like for me its just a quality of life thing to merge those two repos).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing developer experience performance 🚀