feat: implement isSelectableGroup function to filter out unselectable groups#60483
Open
masskrdjn wants to merge 3 commits into
Open
feat: implement isSelectableGroup function to filter out unselectable groups#60483masskrdjn wants to merge 3 commits into
masskrdjn wants to merge 3 commits into
Conversation
… groups Signed-off-by: krazyhell <hellwarrior@riseup.net>
…ttps://github.com/masskrdjn/server into fix-hiding-unselectable-groups-in-account-manager
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hide the virtual guests app group from the account manager groups picker.
The guests app exposes a virtual
guest_appgroup with the display nameGuests. This group cannot be manually assigned from the accounts UI, and selecting it would not apply guest restrictions. This PR treats it like the existing internal groups that are not selectable in the picker, while keeping existing membership data untouched.TODO
distif required by CIChecklist
3. to review, feature component)stable32)Testing
npx vitest --config vitest.local.config.ts rungit diff --checkNote: I could not regenerate the legacy frontend
distlocally. The full legacy build ran out of memory first, then timed out after 20 minutes even withNODE_OPTIONS=--max-old-space-size=8192.AI (if applicable)