Skip to content

feat: implement isSelectableGroup function to filter out unselectable groups#60483

Open
masskrdjn wants to merge 3 commits into
nextcloud:masterfrom
masskrdjn:fix-hiding-unselectable-groups-in-account-manager
Open

feat: implement isSelectableGroup function to filter out unselectable groups#60483
masskrdjn wants to merge 3 commits into
nextcloud:masterfrom
masskrdjn:fix-hiding-unselectable-groups-in-account-manager

Conversation

@masskrdjn
Copy link
Copy Markdown

Summary

Hide the virtual guests app group from the account manager groups picker.

The guests app exposes a virtual guest_app group with the display name Guests. This group cannot be manually assigned from the accounts UI, and selecting it would not apply guest restrictions. This PR treats it like the existing internal groups that are not selectable in the picker, while keeping existing membership data untouched.

TODO

  • Regenerate/update frontend dist if required by CI

Checklist

Testing

  • npx vitest --config vitest.local.config.ts run
    • 46 tests passed
  • git diff --check
    • OK

Note: I could not regenerate the legacy frontend dist locally. The full legacy build ran out of memory first, then timed out after 20 minutes even with NODE_OPTIONS=--max-old-space-size=8192.

AI (if applicable)

  • The content of this PR was partly generated using AI

@masskrdjn masskrdjn requested a review from a team as a code owner May 16, 2026 20:09
@masskrdjn masskrdjn requested review from nfebe, sorbaugh and susnux and removed request for a team May 16, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Hide "unselectable" groups in account manager

1 participant