ci: compile on CI after merge to reduce conflicts and total CI time#60589
Draft
susnux wants to merge 1 commit into
Draft
ci: compile on CI after merge to reduce conflicts and total CI time#60589susnux wants to merge 1 commit into
susnux wants to merge 1 commit into
Conversation
One of the biggest CI problems we currently face are conflicts, not within source code but in compiled assets. So if you have 2 PRs targeting e.g. files then the assets will likely conflict even if the source can be merged without problems. This causes unnecessary CI time and developer frustration. Another really bad example: Dependency updates. So this solution is the currently lived soltion of the `text` app: 1. we add a CI check to forbid checking in compiled assets 2. we adjust the node workflow to no longer check for asset changes 3. we add a CI workflow to compile after merges. For the corner case where a new PR is merged before the compilation has finished this will abort the first compile and start a new one for the current HEAD. So this also reduces the repository size in cases of many quick merged like during dependabot updates. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One of the biggest CI problems we currently face are conflicts, not within source code but in compiled assets.
So if you have 2 PRs targeting e.g. files then the assets will likely conflict even if the source can be merged without problems.
This causes unnecessary CI time and developer frustration.
Another really bad example: Dependency updates.
So this solution is the currently lived solution of the
textapp:For the corner case where a new PR is merged before the compilation has finished this will abort the first compile and start a new one for the current HEAD.
So this also reduces the repository size in cases of many quick merged like during dependabot updates.
TODO
update-node-distBOT_GITHUB_TOKENwith push permission to the branchestextrepository setup for how to do this securelyChecklist
3. to review, feature component)stable32)AI (if applicable)