Drop custom grid & Add vue component library - #1073
Open
kesselb wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the settings UI layout by removing the legacy flex-based “grid system” and adopting CSS Grid, while also introducing @nextcloud/vue form components to improve the External Monitoring configuration UX.
Changes:
- Replaces the custom
.row/.col-*layout system with CSS Grid (.row+.row--cards) and updates affected views/sections accordingly. - Migrates the External Monitoring section to
@nextcloud/vueform components (NcFormBox / NcFormGroup / switches + copy buttons) and adds a suggested token UX. - Updates dependencies and generated build artifacts to include
@nextcloud/vue.
Reviewed changes
Copilot reviewed 13 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/SettingsAdmin.vue | Removes legacy column classes and adjusts layout to rely on CSS Grid. |
| src/main.css | Deletes the old flex “grid system” and defines new CSS Grid-based .row patterns. |
| src/components/SharesSection.vue | Updates share summary layout to use the new grid/card patterns. |
| src/components/SectionHeading.vue | Adds a class hook for heading styling. |
| src/components/NetworkSection.vue | Simplifies layout and moves interface cards to .row--cards. |
| src/components/MonitoringSection.vue | Migrates to @nextcloud/vue form components and adds token suggestion UX. |
| src/components/DiskSection.vue | Switches disk cards to the shared .row--cards grid styling. |
| src/components/ActiveUsersSection.vue | Simplifies markup by removing unused grid wrappers. |
| package.json | Adds @nextcloud/vue dependency. |
| package-lock.json | Locks new transitive dependencies for @nextcloud/vue. |
| js/serverinfo-main.mjs.license | Updates generated license metadata for new deps. |
| js/serverinfo-main.mjs.map.license | Updates generated license metadata for new deps. |
| css/serverinfo-main.css | Updates generated CSS entrypoint import. |
| css/main-C_6xGBMP.chunk.css | Removes old generated chunk (grid + monitoring CSS). |
| css/main-5RcpR5ey.chunk.css | Adds new generated chunk including CSS Grid + @nextcloud/vue component styles. |
Files not reviewed (1)
- css/main-5RcpR5ey.chunk.css: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
auto-fit/minmax replaces the .col-* scale, its breakpoint variants and all media queries. Rows that were only stacked full-width columns lose their wrappers. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Group the endpoint URL, its options and authentication into form groups, make every value copyable and suggest a generated token instead of the yourtoken placeholder. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Screenshots
Example 1
Using CSS grid and removal of exceptions for components ensure a clean look across all components.
The gap between cpu/memory, disk and network interfaces is the same.
Example 2
Using NcFormGroup adds a clean look, removes custom css, and adds the ability to copy the url or command. In addition a strong token is suggested.