Bugfix/noid/use extra shortcut id only when supported

[mahibi]

followup to #6024

• resolve detect warnings

🏁 Checklist

• ⛑️ Tests (unit and/or integration) are included or not needed
• 🔖 Capability is checked or not needed
• 🔙 Backport requests are created or not needed: /backport to stable-xx.x
• 📅 Milestone is set
• 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

[Copilot]

Pull request overview

Follow-up bugfix to Direct Share shortcut handling and lint/detekt warning suppression, ensuring shortcut IDs are only accessed when supported and suppressing long-parameter warnings in Compose UI code.

Changes:

• Added/adjusted @Suppress annotations for Detekt/lint warnings in chat UI composables.
• Added an SDK version gate before reading Intent.EXTRA_SHORTCUT_ID when handling ACTION_SEND in ConversationsListActivity.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
app/src/main/java/com/nextcloud/talk/ui/chat/ChatMessageScaffold.kt	Updates suppression annotations to address Detekt warnings (long method/parameter list).
app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt	Gates reading EXTRA_SHORTCUT_ID behind an SDK check for Direct Share intent handling.

Comments suppressed due to low confidence (1)

app/src/main/java/com/nextcloud/talk/conversationlist/ConversationsListActivity.kt:336

• The new API-level gate (>= Q) prevents handling Direct Share shortcut selection on Android 8–9 (API 26–28), even though the app’s minSdk is 26 and sharing shortcuts exist there. Consider reading the shortcut id using the API 25+ constant (e.g., ShortcutManager.EXTRA_SHORTCUT_ID) and gating on N_MR1 (or removing the gate entirely given minSdk 26), instead of requiring Q.

        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q && hasActivityActionSendIntent()) {
            val shortcutId = intent.getStringExtra(Intent.EXTRA_SHORTCUT_ID)
            if (shortcutId != null) {
                pendingDirectShareToken = DirectShareHelper.extractTokenFromShortcutId(shortcutId)
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

APK file: https://github.com/nextcloud/talk-android/actions/runs/24663965800/artifacts/6530562978
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

APK file: https://github.com/nextcloud/talk-android/actions/runs/24667554244/artifacts/6532108074
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	88	88
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	6	6
Correctness	10	10
Dodgy code	53	53
Internationalization	3	3
Malicious code vulnerability	3	3
Performance	4	4
Security	1	1
Total	80	80