Skip to content

fix(lists): allow to toggle between all types of lists#8536

Merged
mejo- merged 1 commit into
mainfrom
fix/convert_lists
May 11, 2026
Merged

fix(lists): allow to toggle between all types of lists#8536
mejo- merged 1 commit into
mainfrom
fix/convert_lists

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented May 7, 2026 •
edited
Loading

📝 Summary

Overwrites the Tiptap toggle<Type>List commands and uses a new custom convertListType function to replace old list with a new list with similar content when migrating between ordered/bullet and task list.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated content was reviewed, comprehended and tested by me

@mejo- mejo- self-assigned this May 7, 2026
@mejo- mejo- requested a review from max-nextcloud as a code owner May 7, 2026 14:31
@mejo- mejo- added the bug Something isn't working label May 7, 2026
@mejo- mejo- requested a review from silverkszlo as a code owner May 7, 2026 14:31
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team May 7, 2026
@mejo- mejo- force-pushed the fix/convert_lists branch from 5ba0562 to e1bd275 Compare May 7, 2026 21:07
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team May 7, 2026
@mejo-
Copy link
Copy Markdown
Member Author

mejo- commented May 7, 2026

/backport to stable33

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/commands/convertList.ts 96.15% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@mejo-
fix(lists): allow to toggle between all types of lists
ee57ffa 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/convert_lists branch from e1bd275 to ee57ffa Compare May 7, 2026 21:32
max-nextcloud
max-nextcloud approved these changes May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@mejo- mejo- merged commit 30dcb31 into main May 11, 2026
64 checks passed
@mejo- mejo- deleted the fix/convert_lists branch May 11, 2026 07:16
@github-project-automation github-project-automation Bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team May 11, 2026
@backportbot backportbot Bot mentioned this pull request May 11, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@silverkszlo silverkszlo Awaiting requested review from silverkszlo silverkszlo is a code owner

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working

Projects

📝 Productivity team
Status: ☑️ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switching between list types is not possible anymore

2 participants

@mejo- @max-nextcloud