Skip to content

feat: add support for wiki-style link and image Markdown syntax#8562

Open
mejo- wants to merge 3 commits intomainfrom
feat/wiki_links
Open

feat: add support for wiki-style link and image Markdown syntax#8562
mejo- wants to merge 3 commits intomainfrom
feat/wiki_links

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented May 10, 2026 •
edited
Loading

📝 Summary

Adds support for wiki-style link and image Markdown syntax both to markdown-it and to the ProseMirror Markdown serializer.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

🤖 AI (if applicable)

  • The content of this PR was partly generated using AI tools
  • The AI-generated code was reviewed, comprehended and tested by me

@mejo-
feat(markdown): add support for wiki-style image links
6856eb0 
Fixes: #4795

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- self-assigned this May 10, 2026
@mejo- mejo- added bug Something isn't working 3. to review labels May 10, 2026
@mejo- mejo- requested a review from max-nextcloud as a code owner May 10, 2026 19:41
@mejo- mejo- requested a review from silverkszlo as a code owner May 10, 2026 19:41
@github-project-automation github-project-automation Bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team May 10, 2026
@mejo- mejo- mentioned this pull request May 10, 2026
Closed
4 tasks
@mejo-
feat(markdown): add support for wiki-style links
5711ca8 
Doesn't care about resolving the wiki page link when clicking on it.
This is mainly meant to fix breaking Obsidian wiki-style links for now.

Fixes: #4795

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/wiki_links branch 2 times, most recently from 9d6253a to 47570bc Compare May 10, 2026 20:23
@mejo-
chore(test): update commonmark spec test cases
376801b 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feat/wiki_links branch from 47570bc to 376801b Compare May 10, 2026 20:25
@mejo- mejo- changed the title Feat/wiki links feat: add support for wiki-style link and image Markdown syntax May 10, 2026
@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team May 10, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

❌ Patch coverage is 97.89474% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/marks/Link.ts 91.30% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@LuvForAirplanes
Copy link
Copy Markdown

LuvForAirplanes commented May 11, 2026

Amazing work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@silverkszlo silverkszlo Awaiting requested review from silverkszlo silverkszlo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mejo- mejo-

Labels

3. to review bug Something isn't working feature: links format: markdown

Projects

📝 Productivity team
Status: 👀 In review

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The problem of automatic escaping in txt applications Escaping of square brackets breaks links of embedded attachments for external Markdown Editor

2 participants

@mejo- @LuvForAirplanes