Fix problems with userinfo claims by allowing them to be disabled#1348
Merged
julien-nc merged 2 commits intonextcloud:mainfrom Feb 23, 2026
Merged
Conversation
Signed-off-by: Carl Otto Strömstedt <carl.ottostromstedt@gmail.com>
Signed-off-by: Carl Otto Strömstedt <carl.ottostromstedt@gmail.com>
julien-nc
force-pushed
the
optional-userinfo-claims
branch
from
8cb52bc to
9f506f5
Compare
Member
|
Rebased on main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use the the Application with Google as a provider, the following error is returned:
To fix this issue i have added the ability to disable userinfo claims by setting
'send_userinfo_claims' => falsein the config.This adds toggleable compatibility for providers such as Google without breaking current compatibility.
I've tested this fix with my Nextcloud Instance and it fixes the problem at hand.
Fixes: #1121 Google OIDC login fails in user_oidc v7.2.0 due to unconditionally injected claims