Node.js v24 - #291
Open
jameshadfield wants to merge 2 commits into
Open
Conversation
victorlin
approved these changes
Jul 27, 2026
victorlin
left a comment
victorlin
left a comment
Member
There was a problem hiding this comment.
👍 nothing else in the image should depend on Node.js.
jameshadfield
force-pushed
the
auspice-v3
branch
from
September 2, 2026 23:58
05703f8 to
c0f980e
Compare
jameshadfield
marked this pull request as ready for review
September 2, 2026 23:59
In preparation for Auspice v3 which has a minimum nodejs dep of v24
Auspice 3.0.0 now has a prepare` lifecycle script that runs `tsc` (a devDependency) during `npm install`. Our previous `npm install --omit dev` skipped devDependencies but still triggered `prepare`, so the build failed with `tsc: not found`. This new approach allows auspice to install with dev dependencies and then prune them out after linking. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jameshadfield
force-pushed
the
auspice-v3
branch
from
September 3, 2026 03:20
c0f980e to
a93af8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prepares for Auspice v3, which requires Node.js v24.
I tested the first commit (bumping Node.js to v24) in a local image. This worked well with the latest Auspice release (2.73.0), so can we merge this first commit now ahead of Auspice v3? cc @victorlin
The second commit (to be dropped - hence the draft PR) shows that Auspice v3 works as expected in the Docker container. There's deprecation warnings due to how
auspice viewshould now be invoked, but fixing them requires changes in nextstrain/cli: nextstrain/cli#541