Skip to content

Conversation

@dhurley
Copy link
Collaborator

@dhurley dhurley commented Dec 19, 2025

Proposed changes

Ensure watchers are enabled before handling NGINX config context update.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@dhurley dhurley requested a review from a team as a code owner December 19, 2025 11:43
@dhurley dhurley self-assigned this Dec 19, 2025
@github-actions github-actions bot added the chore Pull requests for routine tasks label Dec 19, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.31%. Comparing base (fab01ec) to head (c33eab5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   85.31%   85.31%           
=======================================
  Files         102      102           
  Lines       12974    12974           
=======================================
  Hits        11069    11069           
  Misses       1418     1418           
  Partials      487      487           
Files with missing lines Coverage Δ
internal/watcher/watcher_plugin.go 72.91% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab01ec...c33eab5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants