Forward autocomplete in nimble-text-field - #3016
Closed
kevtan-ni wants to merge 1 commit into
Closed
Conversation
Member
|
@kevtan-ni sorry for the pain point but currently you need to create the branch directly in the nimble repo for all the pipeline steps to run as the chromatic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
nimble-text-field's real lives in shadow DOM. Browsers read that input'sautocompleteattribute to autofill login fields, butnimble-text-fieldwas not forwarding this attribute so username/password fields weren't being recognized.👩💻 Implementation
autocompleteattribute and forward it to the internalinput🧪 Testing
✅ Checklist