Skip to content

Forward autocomplete in nimble-text-field - #3016

Closed
kevtan-ni wants to merge 1 commit into
ni:mainfrom
kevtan-ni:users/kevtan/add-autocomplete-to-text-field
Closed

Forward autocomplete in nimble-text-field#3016
kevtan-ni wants to merge 1 commit into
ni:mainfrom
kevtan-ni:users/kevtan/add-autocomplete-to-text-field

Conversation

@kevtan-ni

Copy link
Copy Markdown
Contributor

Pull Request

🤨 Rationale

nimble-text-field's real lives in shadow DOM. Browsers read that input's autocomplete attribute to autofill login fields, but nimble-text-field was not forwarding this attribute so username/password fields weren't being recognized.

👩‍💻 Implementation

  • Add a public autocomplete attribute and forward it to the internal input

🧪 Testing

  • Added unit tests to verifying autocomplete is forwarded to the internal input when set and absent when unset

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite

rajsite commented Jul 22, 2026

Copy link
Copy Markdown
Member

@kevtan-ni sorry for the pain point but currently you need to create the branch directly in the nimble repo for all the pipeline steps to run as the chromatic UI Tests won't run for a fork (issue to support fork-pull workflows #634). I added you to the nimble team so you should be able to create a branch.
I'll close the current PR but please reach out if running into any issues making a new branch + PR directly on ni/nimble.

@rajsite rajsite closed this Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants