Skip to content

Forward autocomplete in nimble-text-field - #3017

Merged
rajsite merged 2 commits into
mainfrom
users/kevtan/add-autocomplete-to-text-field
Jul 22, 2026
Merged

Forward autocomplete in nimble-text-field#3017
rajsite merged 2 commits into
mainfrom
users/kevtan/add-autocomplete-to-text-field

Conversation

@kevtan-ni

@kevtan-ni kevtan-ni commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Pull Request

🤨 Rationale

Partially addresses #2914

nimble-text-field's real lives in shadow DOM. Browsers read that input's autocomplete attribute to autofill login fields, but nimble-text-field was not forwarding this attribute so username/password fields weren't being recognized.

👩‍💻 Implementation

  • Add a public autocomplete attribute and forward it to the internal input

🧪 Testing

  • Added unit tests to verifying autocomplete is forwarded to the internal input when set and absent when unset

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Comment thread packages/nimble-components/src/text-field/index.ts
@rajsite
rajsite merged commit 793419c into main Jul 22, 2026
12 checks passed
@rajsite
rajsite deleted the users/kevtan/add-autocomplete-to-text-field branch July 22, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants