Fix zero-member serialization macros#5278
Open
dark-ous wants to merge 1 commit into
Open
Conversation
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated and/or formatted correctly. 📎 A ready-to-apply patch is attached to the failed workflow run as the git apply amalgamation.patchThis does not require installing astyle yourself. @dark-ous Please read and follow the Contribution Guidelines. |
dark-ous
force-pushed
the
fix-empty-macro
branch
from
July 17, 2026 15:39
9fb26b0 to
b4c01c1
Compare
Signed-off-by: dark-ous <hitmanbrother233p@gmail.com>
dark-ous
force-pushed
the
fix-empty-macro
branch
from
July 17, 2026 15:44
b4c01c1 to
43828a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4041 by allowing the
NLOHMANN_DEFINE_TYPE_*serialization macros to be used with zero-member types.Previously, invoking these macros on an empty type resulted in invalid macro expansion and compilation failed. With this change, zero-member types can be serialized and deserialized correctly as empty JSON objects (
{}).Example:
Changes
{}).Implementation
The implementation handles the empty variadic argument case by using
##__VA_ARGS__to remove the trailing comma when no member arguments are supplied and introduces a no-opNLOHMANN_JSON_PASTE1expansion for the zero-member case.Testing
109/109tests passed).make amalgamate.