This repository was archived by the owner on Nov 6, 2022. It is now read-only.
Open
Conversation
Added data callback to access data in chunked encoding extensions.
Member
|
Thanks for the PR but please be aware that because it changes the ABI, it can't land until the next major release and that is not expected to happen anytime soon. See #159 from 2013 which adds the same hooks. |
Author
Author
|
Anyway I don't think it's possible to do that without changing structs (I don't think it's good to do some ugly hacks to hide pointer to data and size in some other part of |
Member
|
Yep. That other PR really shouldn't have landed without a major version bump but that wasn't on my watch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are already callbacks to get size of chunk and it's body as well as info when chunk was parsed, but I was missing a clean way to get to chunk extension data. Previously, parser just skipped the extension data as long as it started with space or semicolon.
I also changed tests with non-zero chunk extensions to check whether they were parsed correctly.