Skip to content

src: omit unconvertible names in cjs_lexer::Parse #63943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonrig wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −6
Open

src: omit unconvertible names in cjs_lexer::Parse #63943

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53cc25a
src: omit unconvertible names in cjs_lexer::Parse
anonrig Jun 16, 2026
5279735
Update src/node_cjs_lexer.cc
anonrig Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/node_cjs_lexer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,25 +67,26 @@ void Parse(const FunctionCallbackInfo<Value>& args) {

const auto& analysis = result.value();

// Convert exports to JS Set
// Convert exports to JS Set, omitting any name that cannot be turned into a
// V8 string (e.g. on string allocation failure) instead of aborting.
Local<Set> exports_set = Set::New(isolate);
for (const auto& exp : analysis.exports) {
Local<String> exp_str;
if (!CreateString(isolate, exp).ToLocal(&exp_str) ||
if (CreateString(isolate, exp).ToLocal(&exp_str) &&
exports_set->Add(context, exp_str).IsEmpty()) {
return;
}
}

// Convert reexports to JS array using batch creation
// Convert reexports to JS array, omitting any name that cannot be turned into
// a V8 string.
LocalVector<Value> reexports_vec(isolate);
reexports_vec.reserve(analysis.re_exports.size());
for (const auto& reexp : analysis.re_exports) {
Local<String> reexp_str;
if (!CreateString(isolate, reexp).ToLocal(&reexp_str)) {
return;
if (CreateString(isolate, reexp).ToLocal(&reexp_str)) {
reexports_vec.push_back(reexp_str);
}
reexports_vec.push_back(reexp_str);
}

// Create result array [exports (Set), reexports (Array)]
Expand Down
Loading