Skip to content

Conversation

@avivkeller
Copy link
Member

This PR bumps our Node.js version to v24(.11.0), and our pnpm version to 10.20.

Ref: #8092

Copilot AI review requested due to automatic review settings October 29, 2025 19:47
@avivkeller avivkeller requested review from a team as code owners October 29, 2025 19:47
@vercel
Copy link

vercel bot commented Oct 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Dec 3, 2025 11:08pm

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.22%. Comparing base (43ffe41) to head (fd40c0d).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8289      +/-   ##
==========================================
- Coverage   76.40%   75.22%   -1.18%     
==========================================
  Files         118      107      -11     
  Lines        9928     9151     -777     
  Branches      334      314      -20     
==========================================
- Hits         7585     6884     -701     
+ Misses       2341     2265      -76     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the project's Node.js runtime from v22.14.0 to v24.11.0 and pnpm package manager from 10.13.1 to 10.20.0.

  • Updates Node.js version to v24.11.0 across configuration files
  • Upgrades pnpm to version 10.20.0
  • Removes the manual npm reinstall step from the publish workflow since Node.js v24 comes with npm 11+ by default

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updates packageManager to [email protected] and devEngines to require Node.js >=v24.11.0 and pnpm 10.20.0
.nvmrc Changes Node version from v22.14.0 to v24 (major version only)
.github/workflows/publish-packages.yml Removes npm reinstall step that was needed for OIDC support in Node.js v22

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 94 🟠 88 🟢 100 🟢 100 🔗
/en/about 🟢 100 🟢 93 🟢 100 🟠 88 🔗
/en/about/previous-releases 🟢 99 🟢 93 🟢 100 🟢 100 🔗
/en/download 🟢 98 🟢 96 🟢 100 🟢 100 🔗
/en/download/archive/current 🟢 100 🟢 100 🟢 100 🟢 100 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 100 🔗

@MattIPv4

This comment was marked as outdated.

@avivkeller

This comment was marked as outdated.

@MattIPv4
Copy link
Member

MattIPv4 commented Oct 30, 2025

I see, I think we want to set engines.node to 24.x in the website package itself, which is what will tell Vercel to actually use v24 (which will then fail currently, I believe, as they don't support it).

@avivkeller

This comment was marked as outdated.

@MattIPv4
Copy link
Member

@avivkeller can you try setting engines.node to 24.x in the website? I'd like to see us hit the same failure I hit in alveusgg/alveusgg#1604 (comment) so that we know Vercel is actually looking at the package.json for what version to use?

@avivkeller avivkeller removed the blocked label Dec 3, 2025
@avivkeller
Copy link
Member Author

avivkeller commented Dec 3, 2025

Vercel now supports this version, rebasing now

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.52 MB
New Total Size 3.52 MB
Delta 0 B (0.00%)

Changes

➕ Added Assets (2)
Name Size
.next/static/chunks/588083ee24ac6c94.js 57.96 KB
.next/static/chunks/47f6daefe3158485.js 204.48 KB
➖ Removed Assets (2)
Name Size
.next/static/chunks/e990bd9ed52842cd.js 57.96 KB
.next/static/chunks/f0fd468782f70ba6.js 204.48 KB

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd still like to see engines.node set to 24.x in the website package.json, please, so that Vercel actually builds this with Node.js 24

@avivkeller
Copy link
Member Author

avivkeller commented Dec 3, 2025

Looks like the deployment overrides the Node.js version set (v22). @ovflowd or @bmuenzenmeyer can you change the builds to use v24.x once this lands?

image

https://vercel.com/docs/functions/runtimes/node-js/node-js-versions#setting-the-node.js-version-in-project-settings

Co-authored-by: Matt Cowley <[email protected]>
Signed-off-by: Aviv Keller <[email protected]>
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, Vercel picked up the Node.js version override with that

Image

@avivkeller
Copy link
Member Author

@nodejs/nodejs-website bump

@avivkeller avivkeller added this pull request to the merge queue Dec 6, 2025
Merged via the queue into main with commit 8c49532 Dec 6, 2025
12 checks passed
@avivkeller avivkeller deleted the bump-pnpm-node branch December 6, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants