-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(versioning): bump node to v24, pnpm to v10.20 #8289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8289 +/- ##
==========================================
- Coverage 76.40% 75.22% -1.18%
==========================================
Files 118 107 -11
Lines 9928 9151 -777
Branches 334 314 -20
==========================================
- Hits 7585 6884 -701
+ Misses 2341 2265 -76
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the project's Node.js runtime from v22.14.0 to v24.11.0 and pnpm package manager from 10.13.1 to 10.20.0.
- Updates Node.js version to v24.11.0 across configuration files
- Upgrades pnpm to version 10.20.0
- Removes the manual npm reinstall step from the publish workflow since Node.js v24 comes with npm 11+ by default
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates packageManager to [email protected] and devEngines to require Node.js >=v24.11.0 and pnpm 10.20.0 |
| .nvmrc | Changes Node version from v22.14.0 to v24 (major version only) |
| .github/workflows/publish-packages.yml | Removes npm reinstall step that was needed for OIDC support in Node.js v22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Lighthouse Results
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I see, I think we want to set |
This comment was marked as outdated.
This comment was marked as outdated.
|
@avivkeller can you try setting |
|
Vercel now supports this version, rebasing now |
3b03516 to
6b24139
Compare
📦 Build Size ComparisonSummary
Changes➕ Added Assets (2)
➖ Removed Assets (2)
|
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like to see engines.node set to 24.x in the website package.json, please, so that Vercel actually builds this with Node.js 24
|
Looks like the deployment overrides the Node.js version set (v22). @ovflowd or @bmuenzenmeyer can you change the builds to use v24.x once this lands?
|
Co-authored-by: Matt Cowley <[email protected]> Signed-off-by: Aviv Keller <[email protected]>
MattIPv4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@nodejs/nodejs-website bump |


This PR bumps our Node.js version to v24(.11.0), and our pnpm version to 10.20.
Ref: #8092