-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
docs(learn): add enterprise network configuration guide #8394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8394 +/- ##
==========================================
+ Coverage 76.40% 76.41% +0.01%
==========================================
Files 118 118
Lines 9928 9932 +4
Branches 334 334
==========================================
+ Hits 7585 7590 +5
+ Misses 2341 2340 -1
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive documentation for configuring Node.js applications in enterprise network environments. The guide covers two main areas: proxy configuration (via NODE_USE_ENV_PROXY environment variable or --use-env-proxy flag) and certificate authority configuration (via NODE_USE_SYSTEM_CA environment variable or --use-system-ca flag). The documentation provides practical examples for both CommonJS and ES Module syntax, covering environment variable setup, programmatic configuration, and various edge cases like authenticated proxies and proxy bypass rules.
Key Changes
- New enterprise network configuration guide under
/learn/enterprise/ - Detailed proxy configuration instructions with environment variable and CLI flag options
- Certificate authority configuration guide for using system CA stores
- Code examples in both CommonJS and ES Module formats
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add a guide on how to configure proxies and system CA certificates using the new built-in support.
|
This |
2b451de to
8b4bb44
Compare
Co-authored-by: Copilot <[email protected]> Signed-off-by: Joyee Cheung <[email protected]>
|
Looks like the new guide isn't show automatically. Is there a file I need to edit? Perhaps |
mikeesto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview is available at: https://nodejs-onpertpgz-openjs.vercel.app/en/learn/http/enterprise-network-configuration
LGTM, thanks!
apps/site/pages/en/learn/http/enterprise-network-configuration.md
Outdated
Show resolved
Hide resolved
apps/site/pages/en/learn/http/enterprise-network-configuration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Joyee Cheung <[email protected]>
AugustinMauroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT ! That's super intresing
|
Is there anything else I should do to merge it? (I can push the merge button because I have org-level access, but it feels inappropriate to abuse it in a repo that I am not a collaborator) |
Our contributor guidelines ask for PRs to be open for 48 hours before being merged, then it's good to go : ) |
Add a guide on how to configure proxies and system CA certificates using the new built-in support.
Description
Validation
Related Issues
Check List
pnpm formatto ensure the code follows the style guide.pnpm testto check if all tests are passing.pnpm buildto check if the website builds without errors.