Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Dec 4, 2025

Add a guide on how to configure proxies and system CA certificates using the new built-in support.

Description

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings December 4, 2025 22:49
@joyeecheung joyeecheung requested a review from a team as a code owner December 4, 2025 22:49
@vercel
Copy link

vercel bot commented Dec 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Dec 5, 2025 11:15am

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2025

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.41%. Comparing base (43ffe41) to head (d005c45).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8394      +/-   ##
==========================================
+ Coverage   76.40%   76.41%   +0.01%     
==========================================
  Files         118      118              
  Lines        9928     9932       +4     
  Branches      334      334              
==========================================
+ Hits         7585     7590       +5     
+ Misses       2341     2340       -1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copilot finished reviewing on behalf of joyeecheung December 4, 2025 22:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for configuring Node.js applications in enterprise network environments. The guide covers two main areas: proxy configuration (via NODE_USE_ENV_PROXY environment variable or --use-env-proxy flag) and certificate authority configuration (via NODE_USE_SYSTEM_CA environment variable or --use-system-ca flag). The documentation provides practical examples for both CommonJS and ES Module syntax, covering environment variable setup, programmatic configuration, and various edge cases like authenticated proxies and proxy bypass rules.

Key Changes

  • New enterprise network configuration guide under /learn/enterprise/
  • Detailed proxy configuration instructions with environment variable and CLI flag options
  • Certificate authority configuration guide for using system CA stores
  • Code examples in both CommonJS and ES Module formats

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Add a guide on how to configure proxies and system CA certificates
using the new built-in support.
@avivkeller
Copy link
Member

This fetch error (unrelated to the PR) is driving me nuts. I'm working on a fix now

@joyeecheung
Copy link
Member Author

Looks like the new guide isn't show automatically. Is there a file I need to edit? Perhaps apps/site/navigation.json?

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Michael Esteban <[email protected]>
Signed-off-by: Joyee Cheung <[email protected]>
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! That's super intresing

@joyeecheung
Copy link
Member Author

Is there anything else I should do to merge it? (I can push the merge button because I have org-level access, but it feels inappropriate to abuse it in a repo that I am not a collaborator)

@mikeesto
Copy link
Member

mikeesto commented Dec 6, 2025

Is there anything else I should do to merge it? (I can push the merge button because I have org-level access, but it feels inappropriate to abuse it in a repo that I am not a collaborator)

Our contributor guidelines ask for PRs to be open for 48 hours before being merged, then it's good to go : )

@avivkeller avivkeller added this pull request to the merge queue Dec 6, 2025
Merged via the queue into nodejs:main with commit 60e15bc Dec 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants