refactor: use import aliases in test files#2130
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR updates import paths across the test suite to use TypeScript path aliases instead of relative file paths. New alias mappings are added to Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
test/unit/cli/server.spec.ts (1)
5-10:⚠️ Potential issue | 🟠 MajorMock target path is incorrect for the logger module.
On line 5,
~~/cli/loggerresolves to<root>/cli/logger, but the logger is located atcli/src/logger.ts. The import incli/src/server.tsusesfrom './logger.ts', which resolves tocli/src/logger.ts. This mismatch means the mock will not intercept the logger imports, and tests may run with the actual logger instead of the mock.🔧 Proposed fix
-vi.mock('~~/cli/logger', () => { +vi.mock('~~/cli/src/logger', () => { return { logError: () => {}, logDebug: () => {}, } })
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7ab83e11-1559-41e2-8f3f-c0d54cd1b142
📒 Files selected for processing (58)
test/e2e/helpers/mock-connector-state.tstest/e2e/helpers/mock-connector.tstest/nuxt/components/HeaderConnectorModal.spec.tstest/nuxt/composables/use-colors.spec.tstest/nuxt/composables/use-preferences-provider.spec.tstest/nuxt/composables/use-settings.spec.tstest/unit/app/composables/use-charts.spec.tstest/unit/app/composables/use-number-formatter.spec.tstest/unit/app/router.options.spec.tstest/unit/app/utils/chart-data-buckets.spec.tstest/unit/app/utils/chart-data-prediction.spec.tstest/unit/app/utils/charts.spec.tstest/unit/app/utils/colors.spec.tstest/unit/app/utils/date.spec.tstest/unit/app/utils/download-anomalies.spec.tstest/unit/app/utils/file-icons.spec.tstest/unit/app/utils/formatters.spec.tstest/unit/app/utils/frameworks.spec.tstest/unit/app/utils/install-command.spec.tstest/unit/app/utils/install-scripts.spec.tstest/unit/app/utils/npm/common.spec.tstest/unit/app/utils/package-name.spec.tstest/unit/app/utils/platform-packages.spec.tstest/unit/app/utils/publish-security.spec.tstest/unit/app/utils/run-command.spec.tstest/unit/app/utils/versions.spec.tstest/unit/cli/npm-client.spec.tstest/unit/cli/schemas.spec.tstest/unit/cli/server.spec.tstest/unit/config/env.spec.tstest/unit/scripts/next-version.spec.tstest/unit/search-case-normalization.spec.tstest/unit/server/utils/atproto/lock.spec.tstest/unit/server/utils/code-highlight.spec.tstest/unit/server/utils/dependency-analysis.spec.tstest/unit/server/utils/dependency-resolver.spec.tstest/unit/server/utils/docs/format.spec.tstest/unit/server/utils/docs/render.spec.tstest/unit/server/utils/docs/text.spec.tstest/unit/server/utils/error-handler.spec.tstest/unit/server/utils/file-tree.spec.tstest/unit/server/utils/gravatar.spec.tstest/unit/server/utils/image-proxy.spec.tstest/unit/server/utils/import-resolver.spec.tstest/unit/server/utils/likes-evolution.spec.tstest/unit/server/utils/provenance.spec.tstest/unit/server/utils/readme-loaders.spec.tstest/unit/server/utils/readme.spec.tstest/unit/server/utils/shiki.spec.tstest/unit/shared/types/index.spec.tstest/unit/shared/utils/async.spec.tstest/unit/shared/utils/binary-detection.spec.tstest/unit/shared/utils/dev-dependency.spec.tstest/unit/shared/utils/html.spec.tstest/unit/shared/utils/package-analysis.spec.tstest/unit/shared/utils/parse-package-param.spec.tstest/unit/shared/utils/severity.spec.tsvitest.config.ts
48f95ad to
2a5d9d7
Compare
🔗 Linked issue
N/A
🧭 Context
Currently, most test files uses the path traverse (
../../../...) to import testing modules.📚 Description
~and#serveretc.~~.