Skip to content

bugfix: applications: matter bridge: fixed units #26122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArekBalysNordic merged 1 commit into from
Dec 9, 2025
Merged

bugfix: applications: matter bridge: fixed units #26122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...cations/matter_bridge/src/simulated_providers/simulated_humidity_sensor_data_provider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,8 @@ void SimulatedHumiditySensorDataProvider::TimerTimeoutCallback(k_timer *timer)
reinterpret_cast<SimulatedHumiditySensorDataProvider *>(p);

/* Get some random data to emulate sensor measurements. */
provider->mHumidity =
chip::Crypto::GetRandU16() % (kMaxRandomTemperature - kMinRandomTemperature) +
kMinRandomTemperature;
provider->mHumidity = chip::Crypto::GetRandU16() % (kMaxRandomHumidity - kMinRandomHumidity) +
kMinRandomHumidity;

LOG_INF("SimulatedHumiditySensorDataProvider: Updated humidity value to %d",
provider->mHumidity);
Expand Down
10 changes: 7 additions & 3 deletions applications/matter_bridge/src/simulated_providers/simulated_humidity_sensor_data_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@

class SimulatedHumiditySensorDataProvider : public Nrf::BridgedDeviceDataProvider {
public:
SimulatedHumiditySensorDataProvider(UpdateAttributeCallback updateCallback, InvokeCommandCallback commandCallback) : Nrf::BridgedDeviceDataProvider(updateCallback, commandCallback) {}
SimulatedHumiditySensorDataProvider(UpdateAttributeCallback updateCallback,
InvokeCommandCallback commandCallback)
: Nrf::BridgedDeviceDataProvider(updateCallback, commandCallback)
{
}
~SimulatedHumiditySensorDataProvider() { k_timer_stop(&mTimer); }
void Init() override;
void NotifyUpdateState(chip::ClusterId clusterId, chip::AttributeId attributeId, void *data,
Expand All @@ -21,8 +25,8 @@ class SimulatedHumiditySensorDataProvider : public Nrf::BridgedDeviceDataProvide
static void TimerTimeoutCallback(k_timer *timer);

static constexpr uint16_t kMeasurementsIntervalMs = 10000;
static constexpr uint16_t kMinRandomTemperature = 30;
static constexpr uint16_t kMaxRandomTemperature = 50;
static constexpr uint16_t kMinRandomHumidity = 3000;
static constexpr uint16_t kMaxRandomHumidity = 5000;

k_timer mTimer;
uint16_t mHumidity = 0;
Expand Down
4 changes: 2 additions & 2 deletions ...ations/matter_bridge/src/simulated_providers/simulated_temperature_sensor_data_provider.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ class SimulatedTemperatureSensorDataProvider : public Nrf::BridgedDeviceDataProv

private:
static constexpr uint16_t kMeasurementsIntervalMs = 10000;
static constexpr int16_t kMinRandomTemperature = -10;
static constexpr int16_t kMaxRandomTemperature = 10;
static constexpr int16_t kMinRandomTemperature = -1000;
static constexpr int16_t kMaxRandomTemperature = 1000;

static void TimerTimeoutCallback(k_timer *timer);

Expand Down