-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Updated docbuild workflow postponing zoomin pack #26149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the docbuild workflow to modify the condition for preparing Zoomin uploads. The change simplifies the trigger logic to only run on push events, rather than the previous complex label-based condition for pull requests.
Key Changes
- Modified the condition for the "Prepare Zoomin upload" step to trigger only on push events instead of checking pull request labels
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bf97e75 to
2a728e0
Compare
2a728e0 to
dc5419a
Compare
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: b59b58f193233fd529b9dce4230e9c572c5e20e3 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated docbuild workflow for zoomin pack. Signed-off-by: Francesco Domenico Servidio <[email protected]>
dc5419a to
b59b58f
Compare
|
You can find the documentation preview for this PR here. |
|
I don't see any issues with this and it is a great way to shorten build times. We should merge this right after the release. |
Updated docbuild workflow postponing zoomin pack