Skip to content

Correct mobile vs desktop inconsistency around showing the layer picker button when already in layer picker #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
csillag wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Correct mobile vs desktop inconsistency around showing the layer picker button when already in layer picker #2101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/2101.trivial.ld
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Mobile: don't show the layer picker button when already in layer picker
7 changes: 0 additions & 7 deletions src/app/components/LayerPicker/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import { scopeFreedom, RouteUtils, mergeNetworksInLayerSelector } from '../../ut
import { styled } from '@mui/material/styles'
import KeyboardArrowLeft from '@mui/icons-material/KeyboardArrowLeft'
import { useScreenSize } from '../../hooks/useScreensize'
import { MobileNetworkButton } from '../PageLayout/NetworkButton'

type LayerPickerProps = {
onClose: () => void
Expand Down Expand Up @@ -137,12 +136,6 @@ const LayerPickerContent: FC<LayerPickerContentProps> = ({ isOutOfDate, onClose,
</TabletBackButton>
)}
</div>
<MobileNetworkButton
Copy link
Member

@lukaw3d lukaw3d Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this was intentional design for visual balance

Copy link
Contributor Author

@csillag csillag Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe so. I spelled out my rationale in the PR description, and asked @juresobocan for input.

isOutOfDate={isOutOfDate}
network={activeScope.network}
layer={activeScope.layer}
onClick={onClose}
/>
</TabletActionBar>
)}
<Divider />
Expand Down