Fix __weak keywork position mistake.#102
Open
ychang-brightcove wants to merge 1 commit intoobjcio:masterfrom
Open
Fix __weak keywork position mistake.#102ychang-brightcove wants to merge 1 commit intoobjcio:masterfrom
ychang-brightcove wants to merge 1 commit intoobjcio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Apple's doc: Transitioning to ARC Release Notes,
__weakis type qualifier. So, the correct position of__weakisType * __weak weakPtr, which is weakPtr is a weak pointer points to a variable with Type, instant of__weak Type * notWeakPtr, which is notWeakPtr is a pointer points to a weak variable with Type.Since
constis type qualifier too, replacing__weakbyconstis a easy way to verify it. The following is the example to show the difference:Type * const constPtrandconst Type * ptrToConstType.