fix(package-deps): materialize the Melange library closure - #16124
Draft
Alizter wants to merge 5 commits into
Draft
fix(package-deps): materialize the Melange library closure#16124Alizter wants to merge 5 commits into
Alizter wants to merge 5 commits into
Conversation
Record that a package root reached under a competing virtual implementation does not receive its own link closure. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Exercise library dependencies, private libraries, stubs, redirects, namespaces, virtual implementations, PPX runtime libraries, nested Dune consumers, installed packages, and only-packages masking. Record the current missing-library failures before materializing the closure. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Record that a scoped package layout retains melange_requires metadata without materializing its referenced workspace library. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Make workspace packages declared with (deps (package ...)) expose the ordinary OCaml library closure required by their installed libraries. Materialize only selected library artifacts and generated metadata, including direct redirects, PPX runtime dependencies, and virtual default implementations. Do not follow package metadata: external packages have no reliable package dependency graph, while OCaml library metadata provides the closure consumers resolve. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Compute each workspace root library closure in Melange mode as well as OCaml mode so scoped package layouts satisfy serialized melange_requires edges. Signed-off-by: Ali Caglayan <alizter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #15996 and the regression in #16025. Compute each package-provided library root closure in Melange mode so scoped workspace layouts satisfy serialized
melange_requiresedges.Related to #15511.