-
Notifications
You must be signed in to change notification settings - Fork 81
[IMP] tests: Fixed unit tests after res.bank removal #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsal-odoo
wants to merge
1
commit into
odoo:master
Choose a base branch
from
odoo-dev:master-bank_ux-hsal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
02ca3fc to
a8057a7
Compare
a8057a7 to
a2c5bd1
Compare
Contributor
|
upgradeci retry with base in all versions |
aj-fuentes
reviewed
Dec 19, 2025
aj-fuentes
reviewed
Dec 19, 2025
This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner. task-5145618
a2c5bd1 to
610b827
Compare
aj-fuentes
reviewed
Dec 19, 2025
| util.flush(p1) | ||
| with self.assertRaises(AssertionError), self.assertUpdated("res_bank", ids=[]): | ||
| self.env["res.bank"].create({"name": "Annie Leonhart"}) | ||
| with self.assertRaises(AssertionError), self.assertUpdated("res_partner", ids=[]): |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjmaksoud could you have a quick look if this part is fine? It looks OK to me.
Contributor
|
upgradeci retry with base in all versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This commit fixes the upgrade-util tests that failed due to the removal of res.bank model. The model res.bank was replaced with res.partner.
task-5145618