refactor: 주문 프로세서 인라인 계측 제거 (#119)

[ohhalim]

작업 내용

성능 분석용 계측 코드(stageRecorder.record() 래핑)를 제거해 주문 처리 흐름이 직접 읽히도록 정리했다.

변경 파일

• SyncOrderProcessor: 모든 stageRecorder 래핑 제거
• AcceptedOrderProcessor: 모든 stageRecorder 래핑 제거
• AcceptedOrderService: 모든 stageRecorder 래핑 제거
• OrderTransactionLifecycleRecorder: 미사용 클래스 삭제

배경

stageRecorder는 #52~#78 병목 분석 과정에서 market_lock_wait, transaction_begin, command_queue_wait 등 구간별 지연을 측정하기 위해 추가됐다.
분석이 완료되어 역할이 끝났고, 현재는 비즈니스 로직을 람다로 감싸 흐름을 읽기 어렵게 만들고 있어 제거한다.

정리 후 흐름 (AcceptedOrderService)

Long sequence = marketSequenceAllocator.nextSequence(market.getId());
Wallet wallet = orderAssetLockService.lockTakerWallet(currentUserId, command);
Order order = Order.accepted(...);
orderRepository.save(order);
orderAssetLockService.saveOrderLockLedger(orderLockLedger, command);
eventRecorder.recordOrderAccepted(order);

테스트

• ./gradlew test 전체 통과

Summary by CodeRabbit

• Refactor
  • Simplified internal order processing by removing transaction lifecycle metrics recording infrastructure
  • Streamlined order acceptance and processing workflows through simplified method signatures
  • Eliminated legacy stage-recording mechanisms across service components to improve code maintainability

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f0180e12-f6dd-4f41-af47-ee670e2911b6

📥 Commits

Reviewing files that changed from the base of the PR and between 92d814d and 0c93e70.

📒 Files selected for processing (5)

• src/main/java/com/coinflow/order/service/AcceptedOrderService.java
• src/main/java/com/coinflow/order/service/OrderService.java
• src/main/java/com/coinflow/order/service/metrics/OrderTransactionLifecycleRecorder.java
• src/main/java/com/coinflow/order/service/processor/AcceptedOrderProcessor.java
• src/main/java/com/coinflow/order/service/processor/SyncOrderProcessor.java

💤 Files with no reviewable changes (1)

• src/main/java/com/coinflow/order/service/metrics/OrderTransactionLifecycleRecorder.java

---

📝 Walkthrough

Walkthrough

Removes OrderCreateStageRecorder and OrderTransactionLifecycleRecorder instrumentation from the order processing pipeline. The OrderTransactionLifecycleRecorder class is deleted entirely. SyncOrderProcessor, AcceptedOrderProcessor, and AcceptedOrderService drop the metrics dependencies from their constructors and replace stageRecorder.record(...) wrappers with direct operations. AcceptedOrderProcessor.processAcceptedOrder loses its OrderSide parameter.

Changes

Stage Metrics Removal from Order Processing Pipeline

Layer / File(s)	Summary
Delete OrderTransactionLifecycleRecorder src/main/java/com/coinflow/order/service/metrics/OrderTransactionLifecycleRecorder.java, src/main/java/com/coinflow/order/service/processor/SyncOrderProcessor.java	Entire OrderTransactionLifecycleRecorder Spring component and its nested Metrics class are deleted; corresponding imports are removed from SyncOrderProcessor.
Refactor SyncOrderProcessor src/main/java/com/coinflow/order/service/processor/SyncOrderProcessor.java	Removes stageRecorder and transactionLifecycleRecorder fields, constructor parameters, and assignments. process/executeInTransaction drop metrics/side parameters. createAndSaveOrder, recordAcceptedOrderWithoutTrade, and registerOrderBookSynchronization operate directly without stage wrappers; afterCommit-only synchronization replaces multi-hook callbacks.
Refactor AcceptedOrderProcessor src/main/java/com/coinflow/order/service/processor/AcceptedOrderProcessor.java	Removes OrderCreateStageRecorder field and constructor parameter. processAcceptedOrder signature changes from (Market, OrderSide, Long) to (Market, Long). Match plan and settlement run directly; a new private registerOrderBookSynchronization helper centralizes afterCommit logic.
Clean up AcceptedOrderService and OrderService src/main/java/com/coinflow/order/service/AcceptedOrderService.java, src/main/java/com/coinflow/order/service/OrderService.java	Removes OrderCreateStageRecorder import, field, constructor parameter, and wrappers from AcceptedOrderService; updates enqueueAcceptedOrder to call processAcceptedOrder(market, orderId) without side. Removes createStartedAt timestamp from OrderService.createOrder and drops that argument from syncOrderProcessor.process.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

• refactor: 주문 프로세서 가독성 개선 — 인라인 계측 분리 #119: This PR directly implements the refactoring described in that issue — removing OrderTransactionLifecycleRecorder and OrderCreateStageRecorder instrumentation from SyncOrderProcessor and AcceptedOrderProcessor, and cleaning up instrumentation-only parameters such as createStartedAt and side.

Possibly related PRs

• ohhalim/CoinFlow#118: Modifies the same core classes (AcceptedOrderService, AcceptedOrderProcessor, SyncOrderProcessor) by refactoring transaction/synchronization behavior, with overlapping changes to TransactionSynchronization handling and processor constructor signatures.

Poem

🐇 Hop hop, the timers are gone today,
No more wrappers to slow down the way!
Stage by stage, we watched the clock spin—
Now we just process and let the trades win.
Less code to read, more orders to fill,
A leaner pipeline down Coinflow Hill! 🌸

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title "refactor: 주문 프로세서 인라인 계측 제거" (remove inline instrumentation from order processor) accurately describes the main objective of the changeset—removing instrumentation/stageRecorder code from order processors to improve readability.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor/order-processor-readability

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}