Cody/update screenshots deploy and persistent#1168
Cody/update screenshots deploy and persistent#1168codyjlandstrom wants to merge 5 commits intomainfrom
Conversation
codyjlandstrom
requested review from
ifbyol,
pchico83 and
rlamana
as code owners
✅ Deploy Preview for okteto-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
||
| <p align="center"> | ||
| <Image | ||
| src={require("@site/static/img/private-repositories-deploy-v1.17+.png").default} | ||
| alt="Deploy private repository from git" | ||
| width="650" | ||
| /> | ||
| </p> | ||
|
|
There was a problem hiding this comment.
Do you think it is better to remove this image rather than replace it? Asking because I see that the following steps preserve the screenshots.
| <Image | ||
| src={require("@site/static/img/cleanup-namespace-sleep+1.33.png").default} | ||
| src={require("@site/static/img/cleanup-namespace-sleep+1.42.png").default} | ||
| alt="wake a sleeping resource" |
There was a problem hiding this comment.
Not related to this PR, just for awareness. I just realized the alt attribute isn't accurate here, and also it's repeated several times on this same page. I can send a follow-up PR to fix this.
There was a problem hiding this comment.
Thank you! I think this was a result of me copying and pasting the image code block
There was a problem hiding this comment.
I love this, and I think an animation here provides a lot of value.
That said, this gif weights 7,50MB, which is huge. Can we consider transforming it to a webm video instead? It's way lighter, and browsers handle it in a more efficient way.
There was a problem hiding this comment.
Yes, good call. I'll do that
bgonp
left a comment
bgonp
left a comment
There was a problem hiding this comment.
Approved with comments, but no blockers.
Co-authored-by: Borja González <borja@bgon.es>
Co-authored-by: Borja González <borja@bgon.es>
2 participants
No description provided.