Skip to content

Updated the cpp-sdk library to v0.1.2#123

Open
m-olko wants to merge 4 commits into
mainfrom
cpp_sdk_0.1.2
Open

Updated the cpp-sdk library to v0.1.2#123
m-olko wants to merge 4 commits into
mainfrom
cpp_sdk_0.1.2

Conversation

@m-olko

@m-olko m-olko commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

This PR

Updates evaluation signatures to match newest version of cpp-sdk library, and pinpoints that dependency to specific version from general main branch.

Signed-off-by: Marcin Olko <molko@google.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7cd60a3e-9484-4501-bced-00b1fc43bc59

📥 Commits

Reviewing files that changed from the base of the PR and between 7f90efd and 522633f.

📒 Files selected for processing (1)
  • .github/workflows/ci-format-test-lint.yml

📝 Walkthrough

Walkthrough

FlagdProvider evaluation methods now return absl::StatusOr-wrapped resolution details for all supported value types. Boolean provider tests handle the new result structure, lint configuration is updated, and the Bazel dependency is pinned to v0.1.2.

Changes

Flagd StatusOr API

Layer / File(s) Summary
Evaluation API and implementations
providers/flagd/src/provider.h, providers/flagd/src/provider.cpp
All five evaluation methods now return absl::StatusOr<std::unique_ptr<...ResolutionDetails>>, preserving existing ready and not-ready behavior.
Evaluation result handling tests and linting
providers/flagd/tests/provider_test.cpp, providers/flagd/tests/.clang-tidy, .github/workflows/ci-format-test-lint.yml
Boolean evaluation tests assert successful results and access resolution details through the wrapped pointer; include-cleaner and system-header lint settings are updated.

Dependency release pin

Layer / File(s) Summary
Bazel dependency revision
MODULE.bazel
The openfeature_cpp_sdk override now selects tag v0.1.2 instead of branch main while retaining the same remote URL.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: pinning the cpp-sdk library to v0.1.2.
Description check ✅ Passed The description is related to the changeset and accurately mentions the SDK version update and dependency pinning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Marcin Olko <molko@google.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
providers/flagd/tests/.clang-tidy (1)

5-5: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid disabling misc-include-cleaner for the entire test tree.

Because CI loads this file, the suppression applies to all current and future Flagd tests. Prefer fixing direct-include violations or narrowing the suppression to affected files/lines; if this is required for generated or third-party headers, document and verify that exception.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@providers/flagd/tests/.clang-tidy` at line 5, Remove the global
misc-include-cleaner suppression from the shared Flagd test configuration. Fix
the affected direct-include violations or narrow any necessary suppression to
specific files or lines, documenting and verifying exceptions only for generated
or third-party headers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@providers/flagd/tests/.clang-tidy`:
- Line 5: Remove the global misc-include-cleaner suppression from the shared
Flagd test configuration. Fix the affected direct-include violations or narrow
any necessary suppression to specific files or lines, documenting and verifying
exceptions only for generated or third-party headers.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a12ba63c-ce32-449b-9ee9-b2a4a293c2e7

📥 Commits

Reviewing files that changed from the base of the PR and between 6e8d776 and 7f90efd.

📒 Files selected for processing (1)
  • providers/flagd/tests/.clang-tidy

m-olko added 2 commits July 16, 2026 09:30
Signed-off-by: Marcin Olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant