Updated the cpp-sdk library to v0.1.2#123
Conversation
Signed-off-by: Marcin Olko <molko@google.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFlagdProvider evaluation methods now return ChangesFlagd StatusOr API
Dependency release pin
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Marcin Olko <molko@google.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
providers/flagd/tests/.clang-tidy (1)
5-5: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAvoid disabling
misc-include-cleanerfor the entire test tree.Because CI loads this file, the suppression applies to all current and future Flagd tests. Prefer fixing direct-include violations or narrowing the suppression to affected files/lines; if this is required for generated or third-party headers, document and verify that exception.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@providers/flagd/tests/.clang-tidy` at line 5, Remove the global misc-include-cleaner suppression from the shared Flagd test configuration. Fix the affected direct-include violations or narrow any necessary suppression to specific files or lines, documenting and verifying exceptions only for generated or third-party headers.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@providers/flagd/tests/.clang-tidy`:
- Line 5: Remove the global misc-include-cleaner suppression from the shared
Flagd test configuration. Fix the affected direct-include violations or narrow
any necessary suppression to specific files or lines, documenting and verifying
exceptions only for generated or third-party headers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a12ba63c-ce32-449b-9ee9-b2a4a293c2e7
📒 Files selected for processing (1)
providers/flagd/tests/.clang-tidy
Signed-off-by: Marcin Olko <molko@google.com>
Signed-off-by: Marcin Olko <molko@google.com>
This PR
Updates evaluation signatures to match newest version of cpp-sdk library, and pinpoints that dependency to specific version from general main branch.