docs: mark Kotlin Logging as launched, Domains as in-progress#1373
docs: mark Kotlin Logging as launched, Domains as in-progress#1373typotter wants to merge 2 commits intoopen-feature:mainfrom
Conversation
Logging was shipped in v0.7.2 (PRs open-feature#220, open-feature#221, open-feature#233 in kotlin-sdk). Domains support is in active development. Signed-off-by: Tyler Potter <tyler.john.potter@gmail.com>
✅ Deploy Preview for openfeature ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the compatibility status for the Kotlin SDK's Logging and Domains features from unsupported to partially supported. Feedback indicates that this JSON file is auto-generated, so changes should be made to the source README and applied via the generator script to prevent them from being overwritten. There is also a suggestion to use the full support status if the features are fully implemented.
| "status": "⚠️", | ||
| "path": "/docs/reference/sdks/client/kotlin#logging" | ||
| }, | ||
| "Domains": { | ||
| "status": "❌", | ||
| "status": "⚠️", |
There was a problem hiding this comment.
This file appears to be generated by scripts/sdk-compatibility-generator.ts. Manual edits to this JSON file are likely to be overwritten the next time the generator script is run. To ensure these changes are persistent and the source of truth is maintained, please update the status in the Kotlin SDK README and run the generator script to update this file.
Additionally, if the Logging feature is fully implemented and spec-compliant in v0.7.2 as the description suggests, consider using the ✅ status instead of ⚠️ to indicate full support.
typotter
changed the title
Logging shipped in v0.7.2 (PRs open-feature#220, open-feature#221, open-feature#233 in kotlin-sdk). Domains support is in active development. Signed-off-by: Tyler Potter <tyler.john.potter@gmail.com>
typotter
changed the title
There was a problem hiding this comment.
Hey @typotter, this is done by a GH action automatically.
The open PR is #1370: https://github.com/open-feature/openfeature.dev/pull/1370/changes#diff-6aa82cac11651201fd7d068c9ea7c1f4ebb0dd0f8c0f8eaf956677a50ae3e96fL445
This is currently failing, I will have a look :)
|
The SDK compatibility will be updated once the following is merged: open-feature/dart-server-sdk#113 |
3 participants
Summary
Updates Kotlin SDK compatibility table:
No other SDK entries changed.
Signed-off-by: Tyler Potter tyler.john.potter@gmail.com