Backport Domain and Glossary lazy-loading updates to 1.13

[shah-harshit]

Summary

• Backports OSS feat(ui): update Domain & Glossary components for lazy-load utility pattern #29065 Domain and Glossary lazy-load utility updates on top of Group 10.
• Keeps deleted 1.13 KnowledgeCenter files deleted and preserves the current 1.13 utility surface during conflict resolution.
• Preserves the stacked review flow so this PR only shows Group 11 changes.

Stack

• Base branch: ui/backport-group10-activityfeed-announcement-lazy-1.13
• Previous PR: Backport ActivityFeed and Announcement lazy-loading updates to 1.13 #30128

Testing

• Scoped UI checkstyle sequence on changed source files: organize-imports-cli, ESLint --fix, Prettier.
• git diff --check HEAD~1..HEAD

[greptile-apps]

Too many files changed for review. (161 files found, 100 file limit)

Bypass the limit by tagging @greptile-apps to review.

[gitar-bot]

🚨 Bug: AddDomainForm imports types not exported by interface file

AddDomainForm.component.tsx (lines 67-71) imports DomainFormSelectItem and DomainFormValues from ./AddDomainForm.interface, but that file only exports AddDomainFormProps — neither type is defined or exported anywhere in the codebase (grep confirms they are referenced only in this component). This causes a TypeScript compile error (TS2305 'Module has no exported member'), breaking the build. The type definitions were apparently dropped during backport conflict resolution. Fix by adding the missing type definitions to AddDomainForm.interface.ts (they back DOMAIN_FORM_DEFAULTS, isFormSelectItem, and transformDomainFormData).

Add the missing DomainFormSelectItem and DomainFormValues type definitions to AddDomainForm.interface.ts (adjust field types to match the original PR #29065).:

import { EntityReference } from '../../../generated/entity/type';
import { TagLabel } from '../../../generated/type/tagLabel';

export interface DomainFormSelectItem {
  id: string;
  label?: string;
  value: unknown;
  name?: string;
}

export interface DomainFormValues {
  name: string;
  displayName: string;
  description: string;
  color: string;
  iconURL: string;
  coverImage: File | null;
  tags: DomainFormSelectItem[];
  glossaryTerms: TagLabel[];
  owners: DomainFormSelectItem[];
  experts: DomainFormSelectItem[];
  reviewers: DomainFormSelectItem[];
  domainType: DomainFormSelectItem | null;
  domains?: DomainFormSelectItem;
  dataProductType: DomainFormSelectItem | null;
  visibility: DomainFormSelectItem | null;
  portfolioPriority: DomainFormSelectItem | null;
  extension: Record<string, unknown>;
}

• Apply fix

_{Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 🚫 Blocked 0 resolved / 1 findings

Backports Domain and Glossary lazy-loading components but is blocked by a critical issue where AddDomainForm imports types that are not exported by the interface file.

🚨 Bug: AddDomainForm imports types not exported by interface file

📄 openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:67-71 📄 openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:73-87 📄 openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:102-116

AddDomainForm.component.tsx (lines 67-71) imports DomainFormSelectItem and DomainFormValues from ./AddDomainForm.interface, but that file only exports AddDomainFormProps — neither type is defined or exported anywhere in the codebase (grep confirms they are referenced only in this component). This causes a TypeScript compile error (TS2305 'Module has no exported member'), breaking the build. The type definitions were apparently dropped during backport conflict resolution. Fix by adding the missing type definitions to AddDomainForm.interface.ts (they back DOMAIN_FORM_DEFAULTS, isFormSelectItem, and transformDomainFormData).

Add the missing DomainFormSelectItem and DomainFormValues type definitions to AddDomainForm.interface.ts (adjust field types to match the original PR #29065).

import { EntityReference } from '../../../generated/entity/type';
import { TagLabel } from '../../../generated/type/tagLabel';

export interface DomainFormSelectItem {
  id: string;
  label?: string;
  value: unknown;
  name?: string;
}

export interface DomainFormValues {
  name: string;
  displayName: string;
  description: string;
  color: string;
  iconURL: string;
  coverImage: File | null;
  tags: DomainFormSelectItem[];
  glossaryTerms: TagLabel[];
  owners: DomainFormSelectItem[];
  experts: DomainFormSelectItem[];
  reviewers: DomainFormSelectItem[];
  domainType: DomainFormSelectItem | null;
  domains?: DomainFormSelectItem;
  dataProductType: DomainFormSelectItem | null;
  visibility: DomainFormSelectItem | null;
  portfolioPriority: DomainFormSelectItem | null;
  extension: Record<string, unknown>;
}

🤖 Prompt for agents

Code Review: Backports Domain and Glossary lazy-loading components but is blocked by a critical issue where AddDomainForm imports types that are not exported by the interface file.

1. 🚨 Bug: AddDomainForm imports types not exported by interface file
   Files: openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:67-71, openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:73-87, openmetadata-ui/src/main/resources/ui/src/components/Domain/AddDomainForm/AddDomainForm.component.tsx:102-116

   `AddDomainForm.component.tsx` (lines 67-71) imports `DomainFormSelectItem` and `DomainFormValues` from `./AddDomainForm.interface`, but that file only exports `AddDomainFormProps` — neither type is defined or exported anywhere in the codebase (grep confirms they are referenced only in this component). This causes a TypeScript compile error (TS2305 'Module has no exported member'), breaking the build. The type definitions were apparently dropped during backport conflict resolution. Fix by adding the missing type definitions to `AddDomainForm.interface.ts` (they back `DOMAIN_FORM_DEFAULTS`, `isFormSelectItem`, and `transformDomainFormData`).

   Fix (Add the missing DomainFormSelectItem and DomainFormValues type definitions to AddDomainForm.interface.ts (adjust field types to match the original PR #29065).):
   import { EntityReference } from '../../../generated/entity/type';
   import { TagLabel } from '../../../generated/type/tagLabel';
   
   export interface DomainFormSelectItem {
     id: string;
     label?: string;
     value: unknown;
     name?: string;
   }
   
   export interface DomainFormValues {
     name: string;
     displayName: string;
     description: string;
     color: string;
     iconURL: string;
     coverImage: File | null;
     tags: DomainFormSelectItem[];
     glossaryTerms: TagLabel[];
     owners: DomainFormSelectItem[];
     experts: DomainFormSelectItem[];
     reviewers: DomainFormSelectItem[];
     domainType: DomainFormSelectItem | null;
     domains?: DomainFormSelectItem;
     dataProductType: DomainFormSelectItem | null;
     visibility: DomainFormSelectItem | null;
     portfolioPriority: DomainFormSelectItem | null;
     extension: Record<string, unknown>;
   }

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact

gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}