Backport services, lineage, and data insight lazy-loading updates to 1.13#30136
Conversation
…y pattern (#29066) * feat(ui): update Services & Ingestion components for lazy-load utility pattern Updates Services and Ingestion components to import from extracted pure utility modules. Updates ServiceUtils, IngestionUtils, SchedularUtils imports. Updates service-related pages for consistent utility usage. Ref: open-metadata/openmetadata-collate#4230 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * minor fix * fix checkstyle and tests * fix build * fix checkstyle --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…ttern (#29063) * feat(ui): update Entity & Lineage components for lazy-load utility pattern Updates Entity and Lineage components to import from extracted pure utility modules. Updates LineageUtils, EntityVersionUtils, CanvasUtils imports. Updates EntityBreadcrumbUtils and EntitySummaryPanelUtils references. Ref: open-metadata/openmetadata-collate#4230 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix failing checks * fix build * fix build, checkstyle and tests * fix e2e tests * fix checkstyle * fix failing test --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…load utility pattern (#29069) * feat(ui): update Dashboard, Pipeline, Chart & ML components for lazy-load utility pattern Updates Dashboard, Pipeline, Chart, DataInsight and ML components to import from extracted pure utility modules. Updates DataInsightUtils, MetricUtils imports. Updates APIEndpoint and SearchIndex components for consistent utility usage. Ref: open-metadata/openmetadata-collate#4230 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix test, build and checkstyle --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Too many files changed for review. ( Bypass the limit by tagging |
| jest.mock('../../Customization/GenericProvider/GenericContext', () => ({ | ||
| useGenericContext: jest.fn().mockImplementation(() => ({ | ||
| data: mockData, | ||
| permissions: DEFAULT_ENTITY_PERMISSION, | ||
| onUpdate: mockHandleFeaturesUpdate, | ||
| setDisplayedColumns: jest.fn(), | ||
| })), | ||
| })); |
There was a problem hiding this comment.
💡 Quality: Duplicate jest.mock for GenericContext in test
MlModelFeaturesList.test.tsx now has two jest.mock('../../Customization/GenericProvider/GenericContext', ...) calls (lines 145 and 154) targeting the exact same module path. Jest permits this and the last definition wins, so the earlier block is dead/redundant and misleading. Remove the stale first mock (or merge them) so the effective mock is obvious.
Was this helpful? React with 👍 / 👎
Code Review 🚫 Blocked 0 resolved / 2 findingsBackports lazy-loading updates for services, lineage, and data insight components, but the build is currently blocked by an invalid import in PageViewsByEntitiesChart and duplicate mocks in MlModelFeaturesList. 🚨 Bug: CustomTooltip imported from module that doesn't export it📄 openmetadata-ui/src/main/resources/ui/src/components/DataInsight/PageViewsByEntitiesChart.tsx:44-48 PageViewsByEntitiesChart.tsx now imports Keep CustomTooltip imported from DataInsightUtils (where it is actually exported), matching DailyActiveUsersChart.💡 Quality: Duplicate jest.mock for GenericContext in test📄 openmetadata-ui/src/main/resources/ui/src/components/MlModel/MlModelDetail/MlModelFeaturesList.test.tsx:145 📄 openmetadata-ui/src/main/resources/ui/src/components/MlModel/MlModelDetail/MlModelFeaturesList.test.tsx:154-161 MlModelFeaturesList.test.tsx now has two 🤖 Prompt for agentsOptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Summary
Stack
Testing