Skip to content

Conversation

@cijothomas
Copy link
Member

Avoid running CI checks unnecessarily. Need to validate if this causes any issue with "required check". Hopefully not, as this is a pattern used in other OTel repos too.

Later to be expanded to Go also.

@cijothomas cijothomas requested a review from a team as a code owner December 4, 2025 22:46
@github-actions github-actions bot added the ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores label Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (dfca971) to head (a3ac447).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1529      +/-   ##
==========================================
- Coverage   83.50%   83.48%   -0.02%     
==========================================
  Files         428      428              
  Lines      119410   119410              
==========================================
- Hits        99713    99691      -22     
- Misses      19163    19185      +22     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 84.67% <ø> (-0.04%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.26% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drewrelmas
Copy link
Contributor

Unfortunately, my intuition is that this will break due to required checks. Do you have an example from other opentelemetry repos showing that is not the case?

@cijothomas
Copy link
Member Author

Unfortunately, my intuition is that this will break due to required checks. Do you have an example from other opentelemetry repos showing that is not the case?

It should not break. open-telemetry/opentelemetry-dotnet#5023 is when we tried this in .NET by @CodeBlanch !

@jmacd
Copy link
Contributor

jmacd commented Dec 5, 2025

(We'll see if it breaks!)

@jmacd jmacd added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@jmacd jmacd enabled auto-merge December 5, 2025 19:22
@jmacd jmacd added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@jmacd jmacd added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 5, 2025
@jmacd jmacd added this pull request to the merge queue Dec 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-repo Repository maintenance, build, GH workflows, repo cleanup, or other chores

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants