[otap-df-quiver] Add Write-Ahead-Log (WAL) implementation to Quiver #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be based on logical cursor.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
==========================================
+ Coverage 83.48% 83.74% +0.26%
==========================================
Files 428 433 +5
Lines 118652 121877 +3225
==========================================
+ Hits 99054 102068 +3014
- Misses 19064 19275 +211
Partials 534 534
🚀 New features to boost your workflow:
|
AaronRM
commented
Dec 5, 2025
| "MIT-0", | ||
| "Apache-2.0", | ||
| "Unicode-3.0", | ||
| "BSD-2-Clause", |
Contributor
Author
There was a problem hiding this comment.
Required due to the array-ref transitive dependency (from blake3) using this license. BSD-2-Clause is even more permissive than BSD-3-Clause (which is already allowed here), so I don't believe this should be a concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an implementation of the Quiver write-ahead log (WAL). The most significant change from the initial spec includes a rewrite and clarification of the WAL file rotation and checkpointing mechanism. Documentation has been updated to reflect the new design.