Skip to content

Conversation

@albertlockett
Copy link
Member

part of #1508

Handles filter predicates like severity_text == null or attributes["x"] == null (e.g. doesn't exist) when filtering using the columnar query engine.

It handles all the cases, including when the optional column is not present, when then the ID column (used to join attributes) is not present or null (meaning no attributes), and when attribute batches are entirely absent.

@albertlockett albertlockett requested a review from a team as a code owner December 5, 2025 21:55
@github-actions github-actions bot added rust Pull requests that update Rust code query-engine Query Engine / Transform related tasks query-engine-columnar Columnar query engine which uses DataFusion to process OTAP Batches labels Dec 5, 2025
@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 94.30380% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.51%. Comparing base (dfca971) to head (b0bd265).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
+ Coverage   83.50%   83.51%   +0.01%     
==========================================
  Files         428      428              
  Lines      119410   119720     +310     
==========================================
+ Hits        99713    99990     +277     
- Misses      19163    19196      +33     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 84.68% <ø> (-0.03%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.30% <94.30%> (+0.03%) ⬆️
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@albertlockett albertlockett changed the title Columnar query engine filter handle == null type predicates Columnar query engine filter handle == null filters Dec 5, 2025
@albertlockett albertlockett added this pull request to the merge queue Dec 6, 2025
Merged via the queue into open-telemetry:main with commit 6564239 Dec 6, 2025
33 checks passed
@albertlockett albertlockett deleted the albert/1508-isnull branch December 6, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query-engine Query Engine / Transform related tasks query-engine-columnar Columnar query engine which uses DataFusion to process OTAP Batches rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants