-
Notifications
You must be signed in to change notification settings - Fork 62
Columnar query engine filter handle == null filters
#1538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertlockett
merged 10 commits into
open-telemetry:main
from
albertlockett:albert/1508-isnull
Dec 6, 2025
Merged
Columnar query engine filter handle == null filters
#1538
albertlockett
merged 10 commits into
open-telemetry:main
from
albertlockett:albert/1508-isnull
Dec 6, 2025
+453
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
+ Coverage 83.50% 83.51% +0.01%
==========================================
Files 428 428
Lines 119410 119720 +310
==========================================
+ Hits 99713 99990 +277
- Misses 19163 19196 +33
Partials 534 534
🚀 New features to boost your workflow:
|
== null type predicates== null filters
15 tasks
jmacd
approved these changes
Dec 6, 2025
rust/experimental/query_engine/engine-columnar/src/pipeline/filter.rs
Outdated
Show resolved
Hide resolved
rust/experimental/query_engine/engine-columnar/src/pipeline/filter.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua MacDonald <[email protected]>
Co-authored-by: Joshua MacDonald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
query-engine
Query Engine / Transform related tasks
query-engine-columnar
Columnar query engine which uses DataFusion to process OTAP Batches
rust
Pull requests that update Rust code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #1508
Handles filter predicates like
severity_text == nullorattributes["x"] == null(e.g. doesn't exist) when filtering using the columnar query engine.It handles all the cases, including when the optional column is not present, when then the ID column (used to join attributes) is not present or null (meaning no attributes), and when attribute batches are entirely absent.