Skip to content

Register ProcessResult for reflection in native - #1628

Open
mcruzdev wants to merge 1 commit into
open-workflow-specification:mainfrom
mcruzdev:issue-1627
Open

Register ProcessResult for reflection in native#1628
mcruzdev wants to merge 1 commit into
open-workflow-specification:mainfrom
mcruzdev:issue-1627

Conversation

@mcruzdev

Copy link
Copy Markdown
Collaborator

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:

Special notes for reviewers:

Additional information (if needed):

Closes #1627

Copilot AI lite review requested due to automatic review settings August 19, 2026 18:47
@mcruzdev
mcruzdev requested a review from fjtirado as a code owner August 19, 2026 18:47
…t-config.json

Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Registers ProcessResult for reflection in the GraalVM native-image configuration to support native builds.

Changes:

  • Adds io.serverlessworkflow.impl.executors.ProcessResult to reflect-config.json for reflection access in native image.
  • Enables broad reflective access (constructors/methods/fields/classes) for ProcessResult.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +2 to +16
{
"name": "io.serverlessworkflow.impl.executors.ProcessResult",
"queryAllPublicConstructors": true,
"queryAllDeclaredConstructors": true,
"queryAllPublicMethods": true,
"queryAllDeclaredMethods": true,
"allPublicConstructors": true,
"allDeclaredConstructors": true,
"allPublicMethods": true,
"allDeclaredMethods": true,
"allPublicFields": true,
"allDeclaredFields": true,
"allPublicClasses": true,
"allDeclaredClasses": true
},
Comment on lines +4 to +11
"queryAllPublicConstructors": true,
"queryAllDeclaredConstructors": true,
"queryAllPublicMethods": true,
"queryAllDeclaredMethods": true,
"allPublicConstructors": true,
"allDeclaredConstructors": true,
"allPublicMethods": true,
"allDeclaredMethods": true,
Copilot AI review requested due to automatic review settings August 19, 2026 19:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

impl/core/src/main/resources/META-INF/native-image/io.serverlessworkflow/serverlessworkflow-impl-core/reflect-config.json:16

  • This reflection entry grants full reflective access to constructors/methods/fields/classes (public + declared). In native images, overly-broad reflection configs increase the attack surface and can unintentionally expose internals. Prefer registering only what’s required (e.g., specific constructors and only the fields/methods actually accessed reflectively) and drop the queryAll* flags unless you have a concrete need for agent-based discovery.
  {
    "name": "io.serverlessworkflow.impl.executors.ProcessResult",
    "queryAllPublicConstructors": true,
    "queryAllDeclaredConstructors": true,
    "queryAllPublicMethods": true,
    "queryAllDeclaredMethods": true,
    "allPublicConstructors": true,
    "allDeclaredConstructors": true,
    "allPublicMethods": true,
    "allDeclaredMethods": true,
    "allPublicFields": true,
    "allDeclaredFields": true,
    "allPublicClasses": true,
    "allDeclaredClasses": true
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register ProcessResult for GraalVM native-image reflection

3 participants