Skip to content

WEB-782 Remove Two-Factor Authentication menu item from System page#3216

Merged
IOhacker merged 1 commit intoopenMF:devfrom
JaySoni1:WEB-782-remove-two-factor-authentication-menu-item-from-system-page
Feb 23, 2026
Merged

WEB-782 Remove Two-Factor Authentication menu item from System page#3216
IOhacker merged 1 commit intoopenMF:devfrom
JaySoni1:WEB-782-remove-two-factor-authentication-menu-item-from-system-page

Conversation

@JaySoni1
Copy link
Copy Markdown
Contributor

@JaySoni1 JaySoni1 commented Feb 23, 2026

Changes Made :-

-Removes the "Two-Factor Authentication" menu item from the System page as the feature is not available from the UI.

WEB-782

Before :-

image

After :-

image

Summary by CodeRabbit

  • Revert
    • Removed the Two-Factor Authentication entry from the System settings menu, including its explanatory help text and the expand/collapse control that showed additional details.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 23, 2026

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)
Validation error: Unrecognized key(s) in object: 'pre_merge_checks'
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65839ab and 100f48c.

📒 Files selected for processing (1)
  • src/app/system/system.component.html
💤 Files with no reviewable changes (1)
  • src/app/system/system.component.html

Walkthrough

Removed the Two-Factor Authentication list item from the system component template, including its icon, label, conditional explanatory paragraph, and toggle arrow controls; only template markup was changed.

Changes

Cohort / File(s) Summary
UI Template
src/app/system/system.component.html
Deleted the Two-Factor Authentication mat-list-item block: left icon/label, conditional explanation paragraph (arrowBooleans[14]), right-side arrow icons and click handlers, and surrounding container (≈34 lines removed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • IOhacker
  • alberto-art3ch
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and specifically describes the main change: removing the Two-Factor Authentication menu item from the System page, which directly matches the changeset that removed a 34-line mat-list-item block for this feature.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@JaySoni1 JaySoni1 force-pushed the WEB-782-remove-two-factor-authentication-menu-item-from-system-page branch from 65839ab to 100f48c Compare February 23, 2026 12:39
Copy link
Copy Markdown
Contributor

@IOhacker IOhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IOhacker IOhacker merged commit 76e93d4 into openMF:dev Feb 23, 2026
5 checks passed
@JaySoni1
Copy link
Copy Markdown
Contributor Author

@IOhacker Thank You for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants