fix: allow omitted permission helper flags#115
Open
acomarcho wants to merge 1 commit into
Open
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
857cf5e to
fd87d0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
PR #113 made the public
sandboxandpermission-profileaction inputs optional with empty-string defaults. The downstreamrunCodexExeccode already treats empty values as omitted and falls back to the legacyworkspace-writesandbox when neither input is set.The helper CLI still used Commander
requiredOption()for both flags, so callers that omit either helper flag fail before that existing fallback logic runs. This can break existing CI even though the public action contract says both inputs are optional.What changed
run-codex-exechelper options--sandboxand--permission-profileoptional with""defaults.null; neither input still resolves to--sandbox workspace-write; realsandboxplus realpermission-profileis still rejected.sandbox, omittedpermission-profile, both omitted, and profile selection with either an empty or omitted sandbox flag.dist/main.jsbundle.Testing
corepack pnpm testcorepack pnpm run checkgit diff --check