Skip to content

fix: allow omitted permission helper flags#115

Open
acomarcho wants to merge 1 commit into
openai:mainfrom
acomarcho:fix-optional-permission-profile
Open

fix: allow omitted permission helper flags#115
acomarcho wants to merge 1 commit into
openai:mainfrom
acomarcho:fix-optional-permission-profile

Conversation

@acomarcho

Copy link
Copy Markdown

Why

PR #113 made the public sandbox and permission-profile action inputs optional with empty-string defaults. The downstream runCodexExec code already treats empty values as omitted and falls back to the legacy workspace-write sandbox when neither input is set.

The helper CLI still used Commander requiredOption() for both flags, so callers that omit either helper flag fail before that existing fallback logic runs. This can break existing CI even though the public action contract says both inputs are optional.

What changed

  • Make the internal run-codex-exec helper options --sandbox and --permission-profile optional with "" defaults.
  • Keep the existing behavior after parsing: empty sandbox/profile values still normalize to null; neither input still resolves to --sandbox workspace-write; real sandbox plus real permission-profile is still rejected.
  • Add regression coverage for omitted sandbox, omitted permission-profile, both omitted, and profile selection with either an empty or omitted sandbox flag.
  • Rebuild the checked-in dist/main.js bundle.

Testing

  • corepack pnpm test
  • corepack pnpm run check
  • git diff --check

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@acomarcho

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jul 3, 2026
@acomarcho acomarcho force-pushed the fix-optional-permission-profile branch from 857cf5e to fd87d0d Compare July 3, 2026 07:21
@acomarcho acomarcho changed the title Allow omitted permission helper flags fix: allow omitted permission helper flags Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant