Skip to content

fix(broker): ignore pid/log unlink failures during teardown - #666

Open
Hughhhhcoder wants to merge 1 commit into
openai:mainfrom
Hughhhhcoder:fix/broker-teardown-eperm
Open

fix(broker): ignore pid/log unlink failures during teardown#666
Hughhhhcoder wants to merge 1 commit into
openai:mainfrom
Hughhhhcoder:fix/broker-teardown-eperm

Conversation

@Hughhhhcoder

Copy link
Copy Markdown

Summary

  • guard broker teardown's pid/log unlinkSync calls so Windows EPERM/locked-file failures do not abort cleanup
  • preserve the existing best-effort teardown behavior for already-removed files
  • add a regression test that simulates EPERM on pid/log unlink while confirming teardown still completes and removes the broker socket

Testing

  • node --test tests/broker-lifecycle.test.mjs
  • ./node_modules/.bin/tsc -p tsconfig.app-server.json

Closes #633.

@Hughhhhcoder
Hughhhhcoder requested a review from a team August 22, 2026 06:13
@Hughhhhcoder

Copy link
Copy Markdown
Author

Status update: the current head remains 2d2d62b1a54c95bc610085f95556052610589fba; local npm test passed (91 tests) and tsc -p tsconfig.app-server.json --noEmit passed. GitHub Pull Request CI is currently action_required with zero jobs, so maintainer approval is needed before CI can run. The full build remains locally blocked only by the prebuild dependency on a global codex app-server generate-ts binary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant