Skip to content

feat(providers): add MiniMax as a scan inference provider #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(providers): add MiniMax as a scan inference provider #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cd39ae
feat(providers): add MiniMax as a scan inference provider
octo-patch Aug 4, 2026
fe52a06
fix(providers): type the provider env-key set and align MiniMax test …
octo-patch Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 99 additions & 34 deletions sdk/typescript/src/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import {
type AccountStatus,
} from "./auth.js";
import {
EXTERNAL_CODEX_PROVIDERS,
isExternalModelProvider,
mergedCodexConfig,
scanModelConfiguration,
type CodexSecurityConfig,
Expand Down Expand Up @@ -171,7 +173,7 @@ export type ScanAuthMode = "auto" | "chatgpt" | "api-key";
export type ScanAuthentication =
| {
method: "api_key";
source: "OPENAI_API_KEY" | "CODEX_API_KEY";
source: "OPENAI_API_KEY" | "CODEX_API_KEY" | "MINIMAX_API_KEY";
verified: false;
}
| {
Expand Down Expand Up @@ -203,6 +205,7 @@ export interface ScanPreflight extends DeepScanOptions {
archiveDir?: string;
authentication: ScanAuthentication;
model: string;
modelProvider?: string;
reasoningEffort: string;
maxCostUsd?: number;
}
Expand Down Expand Up @@ -317,8 +320,12 @@ export class CodexSecurity {
authentication: scanAuthentication(
this.#dependencies.environment,
options.auth,
configuration["model_provider"],
),
...model,
...(typeof configuration["model_provider"] === "string"
? { modelProvider: configuration["model_provider"] }
: {}),
...(options.maxCostUsd === undefined
? {}
: { maxCostUsd: options.maxCostUsd }),
Expand Down Expand Up @@ -389,13 +396,29 @@ export class CodexSecurity {
}
checkOpen();

const requestedConfig = await mergedCodexConfig(this.config);
const modelProvider = requestedConfig["model_provider"];
const externalProvider = isExternalModelProvider(modelProvider)
? EXTERNAL_CODEX_PROVIDERS[modelProvider]
: null;
const authentication = scanAuthentication(
this.#dependencies.environment,
options.auth,
modelProvider,
);
const apiKey =
authentication.method === "api_key"
? environmentApiKey(this.#dependencies.environment, modelProvider)
: null;
if (externalProvider !== null && apiKey === null) {
throw new AuthenticationRequiredError(
`Set ${externalProvider.env_key} to run a scan through ${externalProvider.name}.`,
);
}
const scanEnvironment = selectedScanEnvironment(
this.#dependencies.environment,
options.auth,
modelProvider,
);
if (
authentication.method === "stored_credentials" &&
Expand All @@ -418,6 +441,7 @@ export class CodexSecurity {
(path) =>
requireOutputOutsideRepository(protectedRoot, path, "runtime"),
options.auth,
modelProvider,
);
if (
runtime === previousRuntime &&
Expand All @@ -426,8 +450,7 @@ export class CodexSecurity {
) {
await this.#refreshPersistentRuntime(runtime, scanEnvironment, signal);
}
const effectiveConfig =
runtime.effectiveConfig ?? (await mergedCodexConfig(this.config));
const effectiveConfig = runtime.effectiveConfig ?? requestedConfig;
if (runtime.configPath !== undefined) {
await writeCodexConfig(
runtime.configPath,
Expand Down Expand Up @@ -468,11 +491,7 @@ export class CodexSecurity {
? "stored_credentials"
: null;
}
const apiKey =
authentication.method === "api_key"
? environmentApiKey(this.#dependencies.environment)
: null;
if (apiKey !== null) {
if (externalProvider === null && apiKey !== null) {
this.#runtimeCredentialSource = "api_key";
}
if (
Expand Down Expand Up @@ -620,7 +639,11 @@ export class CodexSecurity {
python,
pluginRoot: runtime.plugin.pluginRoot,
environment: {
...selectedScanEnvironment(runtime.environment, options.auth),
...selectedScanEnvironment(
runtime.environment,
options.auth,
modelProvider,
),
CODEX_SECURITY_STATE_DIR: stateDirectory,
},
signal,
Expand Down Expand Up @@ -775,14 +798,21 @@ export class CodexSecurity {
...pluginExecutionEnvironment(
python,
withoutCodexHome(
selectedScanEnvironment(runtime.environment, options.auth),
selectedScanEnvironment(
runtime.environment,
options.auth,
modelProvider,
),
),
),
...(externalProvider === null
? {}
: { [externalProvider.env_key]: apiKey! }),
CODEX_HOME: runtime.codexHome,
...runtimePaths,
};
const codex = this.#dependencies.createCodex({
...(apiKey === null ? {} : { apiKey }),
...(externalProvider !== null || apiKey === null ? {} : { apiKey }),
env: definedEnvironment(
selectedScanEnvironment(environment, "chatgpt"),
),
Expand Down Expand Up @@ -1143,12 +1173,13 @@ export class CodexSecurity {
temporaryRoot?: string,
validateLocation?: (path: string) => void,
auth: ScanAuthMode = "auto",
modelProvider?: unknown,
): Promise<PreparedRuntime> {
this.#requireOpen();
if (this.#runtime !== null) {
const usePersistentCredentials =
scanAuthentication(this.#dependencies.environment, auth).method ===
"stored_credentials";
scanAuthentication(this.#dependencies.environment, auth, modelProvider)
.method === "stored_credentials";
if (
this.#dependencies.prepareRuntime !== undefined ||
this.#runtime.persistentCredentialHome === undefined ||
Expand All @@ -1168,6 +1199,7 @@ export class CodexSecurity {
temporaryRoot,
validateLocation,
auth,
modelProvider,
);
this.#runtimePromise = runtimePromise;
void runtimePromise.catch(() => {
Expand Down Expand Up @@ -1277,17 +1309,19 @@ export class CodexSecurity {
temporaryRoot?: string,
validateLocation?: (path: string) => void,
auth: ScanAuthMode = "auto",
modelProvider?: unknown,
): Promise<PreparedRuntime> {
if (this.#dependencies.prepareRuntime !== undefined) {
return await this.#dependencies.prepareRuntime(this.config, signal);
}
const processEnvironment = selectedScanEnvironment(
this.#dependencies.environment,
auth,
modelProvider,
);
const persistentCredentialHome =
scanAuthentication(this.#dependencies.environment, auth).method ===
"stored_credentials";
scanAuthentication(this.#dependencies.environment, auth, modelProvider)
.method === "stored_credentials";
const codexHome = persistentCredentialHome
? await prepareCodexSecurityCredentialHome(
processEnvironment,
Expand Down Expand Up @@ -1332,11 +1366,13 @@ export class CodexSecurity {
environment: withoutCodexHome(processEnvironment),
signal,
});
const credentialsAvailable = await initialCredentialsAvailable(
processEnvironment,
ambientHome,
codexHome,
);
const credentialsAvailable = isExternalModelProvider(modelProvider)
? false
: await initialCredentialsAvailable(
processEnvironment,
ambientHome,
codexHome,
);
return {
codexHome,
persistentCredentialHome,
Expand Down Expand Up @@ -1828,12 +1864,17 @@ async function collectResult(
export function scanAuthentication(
environment: ProcessEnvironment,
auth: ScanAuthMode = "auto",
modelProvider?: unknown,
): ScanAuthentication {
if (auth === "chatgpt") {
if (auth === "chatgpt" && !isExternalModelProvider(modelProvider)) {
return { method: "stored_credentials", verified: false };
}
const key = environmentApiKeyEntry(environment);
if (auth === "api-key" && key === null) {
const key = environmentApiKeyEntry(environment, modelProvider);
if (
auth === "api-key" &&
key === null &&
!isExternalModelProvider(modelProvider)
) {
throw new AuthenticationRequiredError(
"API-key authentication requires OPENAI_API_KEY or CODEX_API_KEY. " +
"Set a valid API key or use '--auth chatgpt'.",
Expand All @@ -1847,14 +1888,23 @@ export function scanAuthentication(
function selectedScanEnvironment(
environment: ProcessEnvironment,
auth: ScanAuthMode = "auto",
modelProvider?: unknown,
): ProcessEnvironment {
if (auth !== "chatgpt") return environment;
const selectedProviderKey = isExternalModelProvider(modelProvider)
? EXTERNAL_CODEX_PROVIDERS[modelProvider].env_key
: null;
if (auth !== "chatgpt" && selectedProviderKey === null) return environment;
const externalProviderKeys = new Set<string>(
Object.values(EXTERNAL_CODEX_PROVIDERS).map((provider) => provider.env_key),
);
return Object.fromEntries(
Object.entries(environment).filter(
([name]) =>
name.toUpperCase() !== "OPENAI_API_KEY" &&
name.toUpperCase() !== "CODEX_API_KEY",
),
Object.entries(environment).filter(([name]) => {
const key = name.toUpperCase();
if (key === "OPENAI_API_KEY" || key === "CODEX_API_KEY") return false;
if (selectedProviderKey === null) return true;
if (externalProviderKeys.has(key)) return key === selectedProviderKey;
return true;
}),
);
}

Expand All @@ -1872,15 +1922,24 @@ function notifyObserver<Arguments extends unknown[]>(
.catch(() => {});
}

function environmentApiKey(environment: ProcessEnvironment): string | null {
return environmentApiKeyEntry(environment)?.value ?? null;
function environmentApiKey(
environment: ProcessEnvironment,
modelProvider?: unknown,
): string | null {
return environmentApiKeyEntry(environment, modelProvider)?.value ?? null;
}

function environmentApiKeyEntry(environment: ProcessEnvironment): {
source: "OPENAI_API_KEY" | "CODEX_API_KEY";
function environmentApiKeyEntry(
environment: ProcessEnvironment,
modelProvider?: unknown,
): {
source: "OPENAI_API_KEY" | "CODEX_API_KEY" | "MINIMAX_API_KEY";
value: string;
} | null {
for (const requested of ["OPENAI_API_KEY", "CODEX_API_KEY"] as const) {
const keys = isExternalModelProvider(modelProvider)
? [EXTERNAL_CODEX_PROVIDERS[modelProvider].env_key]
: (["OPENAI_API_KEY", "CODEX_API_KEY"] as const);
for (const requested of keys) {
const canonical = environment[requested]?.trim();
if (canonical) return { source: requested, value: canonical };
for (const [name, value] of Object.entries(environment)) {
Expand Down Expand Up @@ -2107,6 +2166,12 @@ export function scanPreflightCodexConfig(
};

const result = executionConfig(config);
const modelProvider = result["model_provider"];
if (isExternalModelProvider(modelProvider)) {
result["model_providers"] = {
[modelProvider]: { ...EXTERNAL_CODEX_PROVIDERS[modelProvider] },
};
}
const selectedProfile = safeProfileName(config["profile"])
? config["profile"]
: undefined;
Expand Down
Loading