Skip to content

Route review/start through a bundled review skill#31841

Open
jif-oai wants to merge 2 commits into
mainfrom
jif/review-as-skill
Open

Route review/start through a bundled review skill#31841
jif-oai wants to merge 2 commits into
mainfrom
jif/review-as-skill

Conversation

@jif-oai

@jif-oai jif-oai commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Why

review/start currently invokes a bespoke core review task with its own prompt, model switching,
output parsing, and review-mode events. That duplicates orchestration the regular agent already
knows how to do.

This keeps the app-server API while moving its implementation to a normal delegated turn backed by
an explicit bundled skill.

What changed

  • add an explicit-only bundled $review-agent skill with the defect-first rubric and merge-base
    guidance for base-branch reviews
  • translate each review target into a synthetic user prompt that tells the parent to spawn one
    reviewer, wait for it, close it after collecting the response when supported, and return that
    response
  • submit ordinary user input for both inline and detached delivery instead of Op::Review
  • keep the app-server invariants that still matter: bundled skills must be enabled, inline delivery
    requires an idle thread, and detached delivery remains available from multi-agent v2 child
    threads
  • document the normal turn and collaboration event flow while retaining legacy review-mode item
    types for rollout replay

Behavior changes

  • new reviews emit normal turn, collaboration, and agentMessage events instead of
    enteredReviewMode and exitedReviewMode
  • inline review requests now fail clearly when the thread already has an active turn
  • if collaboration tools are unavailable, the parent returns an explanation instead of reviewing
    the change itself
  • reviewer workers use ordinary collaboration lineage and lifecycle semantics; this path no longer
    applies review_model, review-specific metadata, or bespoke review-task restrictions

Follow-up

#31923 removes the now-unused core review session, task, prompt resolver, protocol operation, and
one-shot delegate path while retaining serialized legacy review events for rollout replay.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee4729b415

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/app-server/src/request_processors/turn_processor.rs Outdated
Comment thread codex-rs/app-server/src/request_processors/turn_processor.rs
Comment thread codex-rs/app-server/src/request_processors/turn_processor.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant