Route review/start through a bundled review skill#31841
Open
jif-oai wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee4729b415
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6367d73 to
50c4e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
review/startcurrently invokes a bespoke core review task with its own prompt, model switching,output parsing, and review-mode events. That duplicates orchestration the regular agent already
knows how to do.
This keeps the app-server API while moving its implementation to a normal delegated turn backed by
an explicit bundled skill.
What changed
$review-agentskill with the defect-first rubric and merge-baseguidance for base-branch reviews
reviewer, wait for it, close it after collecting the response when supported, and return that
response
Op::Reviewrequires an idle thread, and detached delivery remains available from multi-agent v2 child
threads
types for rollout replay
Behavior changes
agentMessageevents instead ofenteredReviewModeandexitedReviewModethe change itself
applies
review_model, review-specific metadata, or bespoke review-task restrictionsFollow-up
#31923 removes the now-unused core review session, task, prompt resolver, protocol operation, and
one-shot delegate path while retaining serialized legacy review events for rollout replay.