Conversation
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Redirects are new requests whose destinations may require different PAC or OS proxy decisions. Leaving redirect handling inside one reqwest client would reuse the original route, while a custom loop also has to preserve reqwest's timeout, method/body, Referer, and credential-stripping behavior.
What changed
RouteAwareClientPoolso every hop resolves its own complete URL.Refererbehavior.Review guide
http-client/src/route_aware_redirect.rscontains the redirect transformation and origin rules.sendloop inroute_aware_client_pool.rsapplies those rules while re-resolving each hop.outbound_proxy_tests.rs,route_aware_redirect_tests.rs, and the integration test cover the behavior and privacy invariants.Validation
just test -p codex-http-clientStack created with Sapling. Best reviewed with ReviewStack.