exec-server: support pending environment readiness#31988
Open
sayan-oai wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@codex review this |
Contributor
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CCA environments only have a stable exec-server URL once the filesystem and execution environment are genuinely ready. Requiring that URL during registration forces those providers either to delay registration or to expose an endpoint before the environment can actually be used.
This change lets an in-process provider register the environment ID immediately and publish the stable URL at the provider's canonical readiness transition. Codex then follows the existing WebSocket connection and initialization path, so downstream environment selection and
wait_for_environmentbehavior continue to use the established readiness contract.What changed
EnvironmentManagermethods to register a pending environment, publish its exec-server URL, or fail and remove itExecServerUrlsource used by the existing WebSocket transportstartingtoreadyandstartingtounavailabletransitions through the core deferred-environment flow