fix(jsonview): avoid width underflow in static string rendering - #117
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
fix(jsonview): avoid width underflow in static string rendering#117sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid converting a negative remaining display width into an enormous unsigned truncation limit when rendering static JSON strings in narrow terminals.
Problem
formatResultcurrently truncates long strings with:Object and array rendering can pass a non-positive
widthafter subtracting the rendered key or numbering width. Convertingwidth-1touintthen wraps the negative value to a very large number, so the string is effectively not truncated and can spill far beyond the available terminal width.Fix
Centralize string-width handling in a small helper that:
uint.Normal-width output is unchanged.
Regression coverage
Added focused tests covering:
Validation
The branch is based directly on current upstream
main(ee92673a416c0851a5fe8907a2453db7bd450633) and contains one signed commit touching only the static JSON renderer and its focused regression test. Full Go test execution is left to repository CI.Risk
Low. The behavior change is limited to string values whose available display width is zero or too small to contain the original value.