fix(ci): preserve release source in Maven provenance - #951
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom code✅ No new custom-code files detected. 53 mixed files remain; 0 existing customizations changed. Compared 53 existing customizations unchanged
13 more in the full report. A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33141383080 --repo openai/openai-java \
--name castiron-custom-code-33141383080-1 --dir /tmp/castiron-custom-code-33141383080-1
git apply --stat /tmp/castiron-custom-code-33141383080-1/custom-code.patch
cat /tmp/castiron-custom-code-33141383080-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 9684d5255f5a6b52234ad4dee461300ac2bc9e5a 3934ccdb3f248416afb61605825663ae762262cf
python3 scripts/castiron/custom_code_report.py report \
--base 9684d5255f5a6b52234ad4dee461300ac2bc9e5a \
--head 3934ccdb3f248416afb61605825663ae762262cf --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-3934ccdb3f24
cat /tmp/castiron-custom-code-3934ccdb3f24/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Reviewed the exact current head. The provenance statement restores the workflow ref/SHA as the canonical first resolved dependency while preserving the checked-out release tag/source commit as the second dependency, with policy coverage for both identities. No blocking findings. (GitHub does not permit this account to formally approve its own PR.)
## Summary - stop the pre-GraalVM Gradle daemon before switching JVMs in the Maven publish job - serialize only the final publish graph so concurrent Dokka tasks do not exhaust the standard runner - add policy coverage that locks both stability controls to their intended workflow positions ## Context Follow-up to openai#951. The provenance fix is working, but three guarded v4.53.0 recovery attempts were canceled during the cold Gradle/Dokka publication phase. Logs show the first Gradle daemon remains alive after the JVM switch and multiple Dokka tasks start concurrently during publication. ## Verification - JAVA_HOME=/opt/homebrew/Cellar/openjdk@21/21.0.12/libexec/openjdk.jdk/Contents/Home GRADLE_USER_HOME=/tmp/openai-java-gradle-950 ./gradlew :buildSrc:test lintKotlin --no-daemon - git diff --check - security diff review: clean - adversarial review: round 1 found and fixed a test-coverage gap; rounds 2 and 3 clean ## Security - preserves the fresh private release Gradle User Home and cache-disabled setup - preserves tag/source verification, provenance attestation, digest continuity, SHA-pinned actions, and publish-step-only signing secrets - adds no permissions, actions, cache restore, artifact handoff, or runner dependency
Automated Release PR --- ## [4.55.0](openai/openai-java@v4.54.0...v4.55.0) (2026-08-31) ### Features * **api:** add compute_units to Responses and Chat Completions usage ([openai#944](openai#944)) ([3e45ffb](openai@3e45ffb)) * **auth:** add X.509 token exchange ([openai#940](openai#940)) ([df0c88d](openai@df0c88d)) * integrate X.509 workload identity with OkHttp clients ([openai#948](openai#948)) ([9684d52](openai@9684d52)) ### Bug Fixes * **auth:** bind X.509 bearer attachment to its mTLS transport ([openai#949](openai#949)) ([5f3ab4a](openai@5f3ab4a)) * bind X.509 transport clients to trusted origins ([openai#946](openai#946)) ([bccb100](openai@bccb100)) * **ci:** preserve release source in Maven provenance ([openai#951](openai#951)) ([0382c7c](openai@0382c7c)), closes [openai#950](openai#950) * **ci:** reduce Maven publish runner pressure ([openai#953](openai#953)) ([02b2d0d](openai@02b2d0d)) * fail closed when protected X.509 verification cannot run ([openai#945](openai#945)) ([24089bd](openai@24089bd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Summary
Verification
Fixes #950