chore(deps-dev): bump pyright from 1.1.399 to 1.1.413 - #3744
Conversation
Bumps [pyright](https://github.com/Microsoft/pyright/tree/HEAD/packages/pyright) from 1.1.399 to 1.1.413. - [Release notes](https://github.com/Microsoft/pyright/releases) - [Commits](https://github.com/Microsoft/pyright/commits/1.1.413/packages/pyright) --- updated-dependencies: - dependency-name: pyright dependency-version: 1.1.413 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Castiron custom code✅ No new custom-code files detected. 34 mixed files remain; 0 existing customizations changed. Compared 34 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 33122015404 --repo openai/openai-python \
--name castiron-custom-code-33122015404-1 --dir /tmp/castiron-custom-code-33122015404-1
git apply --stat /tmp/castiron-custom-code-33122015404-1/custom-code.patch
cat /tmp/castiron-custom-code-33122015404-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 4f5598c8d822fcc281bb8862e424fa6ead310ca8 7c5a2fee8c91f85144f0079bc34bc4676d4660de
python3 scripts/castiron/custom_code_report.py report \
--base 4f5598c8d822fcc281bb8862e424fa6ead310ca8 \
--head 7c5a2fee8c91f85144f0079bc34bc4676d4660de --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-7c5a2fee8c91
cat /tmp/castiron-custom-code-7c5a2fee8c91/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04b34fea2e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Pyright 1.1.413 is incompatible with the repository's current required type-checking gate.
After fixing the directly introduced Node-tooling fixture mismatch in 21cd2d5, the required lint check advances to Pyright and fails with five diagnostics:
src/openai/_response.py:246:reportUnknownArgumentTypewhen callingis_basemodel.tests/lib/test_bedrock_credential_chain.py:104:reportDeprecatedfor a@contextmanagerannotated withIteratorinstead ofGenerator.tests/test_module_client.py:110: the same@contextmanagerdeprecation.tests/test_mtls_http_client.py:47: the same@contextmanagerdeprecation.tests/utils.py:170: the same@contextmanagerdeprecation.
Evidence: https://github.com/openai/openai-python/actions/runs/33119108415/job/98681276150
The upgrade therefore cannot pass required CI as a narrowly scoped manifest/lockfile update. Correcting these diagnostics would additionally modify core SDK runtime code and four otherwise unrelated test modules, materially expanding this Dependabot PR across ownership boundaries. Please retain the existing Pyright pin or first land a separately approved, SDK-owner-reviewed compatibility migration, then retry the dependency update. The existing fail-closed supply-chain controls and lint rules should remain unchanged.
# Conflicts: # package.json
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Approved after the explicitly authorized Pyright compatibility fixes, independent adversarial/security review, passing Python 3.10/3.14 and HTTPX2 suites, green full lint/build/breaking-change checks, and both authentic Castiron statuses.
Bumps pyright from 1.1.399 to 1.1.413.
Release notes
Sourced from pyright's releases.
... (truncated)
Commits
71f6760Bump version to 1.1.413 (#11636)8df447dBump version to 1.1.412 (#11624)c9315a2Bump version to 1.1.411 (#11523)a147f88Pull Pylance with Pyright 1.1.410 (#11522)de5220aPull Pylance with Pyright 1.1.410 (#11506)92235e0Publish version 1.1.410 (#11461)4cc1392Update rspack dependencies to version 2.0.4 (#11458)4243a1bBump node-forge from 1.3.3 to 1.4.0 in /packages/pyright (#11422)8f9807eBump fast-uri from 3.1.0 to 3.1.2 in /packages/pyright (#11428)53969cffix: restore axios 1.16.0 and correct minimatch/npm-check-updates regressions...Maintainer changes
This version was pushed to npm by microsoft1es, a new releaser for pyright since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)