fix: escalate portable repair failures to the reclone fallback - #129
Merged
Conversation
When reset/pull repair of a portable store checkout fails - for example because the Git index or metadata is corrupted, the class behind this week's broken-checkout incident - both the corruption recovery path and the missing-source recovery path now escalate to the existing reclone fallback instead of giving up. Escalation is bounded by a 15-minute backoff on a new last_reclone_attempt stamp recorded for successful and failed attempts alike, the recovery state directory is created before the stamp is persisted so a fresh install cannot loop unbounded, and all healthy-mirror fallbacks are preserved.
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: escalate portable repair failures to the reclone fallback This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
osolmaz
pushed a commit
to osolmaz/gitcrawl
that referenced
this pull request
Jul 29, 2026
…law#129) When reset/pull repair of a portable store checkout fails - for example because the Git index or metadata is corrupted, the class behind this week's broken-checkout incident - both the corruption recovery path and the missing-source recovery path now escalate to the existing reclone fallback instead of giving up. Escalation is bounded by a 15-minute backoff on a new last_reclone_attempt stamp recorded for successful and failed attempts alike, the recovery state directory is created before the stamp is persisted so a fresh install cannot loop unbounded, and all healthy-mirror fallbacks are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #128.
When reset/pull repair fails—corrupt Git index/metadata, the class behind the 2026-07-26 broken-checkout incident—both the corruption and missing-source recovery paths now escalate to the existing reclone fallback.
Reclone attempts are bounded by a 15-minute backoff on a new
last_reclone_attemptstamp recorded for successful and failed attempts. The state directory is created before persisting the stamp so fresh installs cannot loop unbounded. Healthy-mirror fallbacks are preserved.Proof:
.git/index, pre-seeded backoff, failed-reclone-still-stamps-backoff across two reads, and missing-source escalation.-count=2flake check on the new tests.