feat(docs): add document enumerator commands#723
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 10, 2026, 1:11 AM ET / 05:11 UTC. Summary Reproducibility: not applicable. for a new feature PR: source review can verify the command shape, but there is no broken current-main behavior to reproduce. The missing evidence is live Google Docs output from the new commands, not a bug reproduction path. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the command family after the contributor adds redacted live output or a terminal screenshot showing the enumerators against a real Google Doc, followed by normal maintainer review. Do we have a high-confidence way to reproduce the issue? Not applicable for a new feature PR: source review can verify the command shape, but there is no broken current-main behavior to reproduce. The missing evidence is live Google Docs output from the new commands, not a bug reproduction path. Is this the best way to solve the issue? Yes, based on source review this is a narrow implementation path for exposing indices and object IDs that existing Docs write commands consume. The remaining blocker is real Google Docs behavior proof, not a different code direction. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 0a7e6425384b. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
@clawsweeper re-review Addressed the tab-scoped image object map finding in e906e3d. Local validation on the updated branch:
|
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
gog docs tables/images/headings/paragraphs listread-only enumerator subcommands--plain, and readable default outputFixes #719
Validation
go test ./internal/cmd -run 'TestDocsEnumerate|TestDocsHeadingsList_TabJSON|TestDocsParagraphsList_PlainTSV'go test ./internal/cmdmake docs-commandsmake fmtmake ci