feat(docs): style fenced markdown code blocks#724
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 10, 2026, 3:14 AM ET / 07:14 UTC. Summary Reproducibility: yes. from source inspection: current main's MarkdownToDocsRequests emits Courier New and only weightedFontFamily for fenced code blocks. I did not run a live Google Docs reproduction. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the scoped local-renderer style change only after redacted live Docs readback proves it and maintainers accept the hard-coded style while treating Drive-import whole-document replace as separate scope. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main's MarkdownToDocsRequests emits Courier New and only weightedFontFamily for fenced code blocks. I did not run a live Google Docs reproduction. Is this the best way to solve the issue? Mostly yes: the implementation is the narrow local-renderer change for the requested style, but merge should wait for live Docs proof and maintainer acceptance of the hard-coded style scope. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against b34e3033913a. Label changesLabel justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
615fe44 to
fd89f24
Compare
fd89f24 to
00bab20
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
@clawsweeper re-review |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
|
Sanitized proof for this PR:
go test -v ./internal/cmd -run 'TestMarkdownToDocsRequests_AppendBulletsAndCode|TestDocsWrite_MarkdownAppendUsesDocsFormatting|TestDocsWrite_MarkdownAppendStartsStyledBlocksOnFreshParagraph' -count=1
{"fields":"weightedFontFamily,foregroundColor","fontFamily":"Roboto Mono","fontWeight":400,"range":{"startIndex":1,"endIndex":19},"rgbHex":"#188038"}This verifies the generated Docs API text-style request for fenced Markdown code blocks includes |
|
@clawsweeper re-review |
|
🦞👀 Command router queued. I will update this comment with the next step. Re-review progress:
|
Summary
Fixes #676.
Scope note
This intentionally covers the local Docs API renderer used by append, tab-replace, range update, and markdown find-replace paths. Whole-document
docs write --replace --markdownstill uses Drive import, so maintainers should decide whether that remains separate issue scope.Validation
Proof
Local tests verify the generated Docs API requests include weightedFontFamily=Roboto Mono and foregroundColor=#188038. I did not run live Google Docs rendering proof in this environment.