feat(eval): add auditable native matrix runner - #42
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 27, 2026, 1:34 PM ET / 17:34 UTC. ClawSweeper reviewWhat this changesAdds a native ShellBench matrix runner that plans and executes multi-harness benchmark jobs, records provenance and real Codex trajectories, checkpoints/export results, and aggregates only reconciled eligible results. Merge readinessKeep this draft PR open. It is a substantial new evaluation and fleet-control capability linked to the still-open canonical request, and adopting its privileged AWS/Crabbox execution path and leaderboard-integrity contract needs explicit product and operational approval rather than cleanup closure. Priority: P3 Review scores
Verification
How this fits togetherShellBench evaluation jobs turn a task suite and planned model/harness matrix into remote benchmark runs, archived artifacts, and aggregated ranking data. This PR introduces a native AWS/Crabbox execution route alongside Harbor-compatible artifacts and eligibility checks. flowchart LR
A[Task suite and matrix plan] --> B[Native fleet controller]
B --> C[AWS Crabbox workers]
C --> D[Harness and proxy execution]
D --> E[Run manifests and checkpoints]
E --> F[Result reconciliation]
F --> G[Eligible aggregate reports]
Decision needed
Why: The patch is an implementation of a new operational and ranking-integrity contract, not a pre-existing narrowly defined behavior; maintainers must choose the supported execution and calibration boundary before code review alone can settle acceptance. Before merge
Findings
Agent review detailsSecurityNeeds attention: The patch adds a root-level remote bootstrap and third-party toolchain installation path, which warrants operational security review before the workflow is adopted. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Adopt the native route only after maintainers define its supported operating boundary and ranking policy, then land it with a redacted end-to-end Crabbox run showing manifest provenance, recovery from a checkpoint, and an eligible aggregate export. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new native evaluation route rather than reporting a current broken behavior; the relevant validation is an end-to-end fleet and artifact-recovery demonstration. Is this the best way to solve the issue? Unclear: the implementation is coherent with the linked proposal, but adding a repository-owned AWS/Crabbox runner is not yet shown to be the best supported product boundary compared with an experimental or externally operated route. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 28ce18e5dfc8. LabelsLabel changes:
Label justifications:
EvidenceSecurity concerns:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
What does this PR do?
Adds a native ShellBench matrix runner with Harbor-compatible task execution, results, manifests, checkpoints, and aggregation.
Why?
The July 27 native matrix exposed three ranking-integrity gaps: planned provider identity could drift at dispatch, non-Codex routes emitted synthetic trajectories, and duplicate or unexpected task results could enter scoring. Artifact pulls also needed crash-safe recovery.
Fixes #41.
Changes
Tests
python -m pytest -qpasses locallypython -m ruff check clawbench app.py scripts testspasses locally, or the change is docs-onlyFocused validation:
55 passed; Ruff,bash -n,shellcheck, andgit diff --checkpassed. ShellCheck reports only the existing informational/etc/os-releasesource notice.