fix: apply native reasoning effort to harnesses - #54
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 30, 2026, 2:59 PM ET / 18:59 UTC. ClawSweeper reviewWhat this changesCarries a native evaluation plan’s reasoning-effort setting through the run specification and manifest, then applies each harness’s supported OpenClaw, Hermes, Codex, or Claude Code control. Merge readinessKeep this member-authored PR open for maintainer review. The focused patch directly addresses the linked benchmark-validity bug, has no actionable code defect in the supplied diff, and needs confirmation against the installed native client versions before merge. Priority: P1 Review scores
Verification
How this fits togetherShellBench builds a native evaluation run plan, converts it into a harness command and per-run configuration, and records the selected settings in a manifest. The changed path ensures the planned reasoning level reaches each client so benchmark results reflect the intended comparison settings. flowchart LR
A[Evaluation plan] --> B[Run specification]
B --> C[Harness command builder]
B --> D[Run manifest]
C --> E[OpenClaw Hermes Codex Claude Code]
E --> F[Native evaluation run]
D --> G[Benchmark comparison records]
Decision needed
Why: The patch is mechanically focused, but its correctness depends on four external client contracts that string-construction tests cannot fully prove in this checkout review. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Confirm one real native run per harness at a non-default effort level, verify the manifest and client invocation agree, then merge the focused parity fix. Do we have a high-confidence way to reproduce the issue? No high-confidence live reproduction was executed in this review. The supplied linked report and branch diff make the original mismatch source-reproducible: a planned effort could diverge from the hard-coded OpenClaw thinking setting. Is this the best way to solve the issue? Yes, conditionally. Carrying the planned value through the shared run specification and mapping it at each harness boundary is the narrowest maintainable fix, provided native client compatibility is confirmed before merge. AGENTS.md: unclear because the file could not be read completely. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
What does this PR do?
Propagates the native eval plan's reasoning effort into OpenClaw, Hermes,
Codex, and Claude Code client controls.
Why?
Fixes #53. Without this, a run can be labeled
highwhile OpenClaw executeswith thinking disabled, invalidating cross-harness quality and efficiency
comparisons.
Changes
reasoning_effortinRunSpecand the run manifestxhighto Claude Code'smaxlow,medium,high, andxhighacross all four harnessesTests