Make get_window deterministic by allowing reference time injection #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR refactors
get_windowto accept an optionalreference_timeparameter (defaulting to
now()in UTC).This makes the function deterministic and easier to test, while
preserving existing behaviour for all current call sites.
A small unit test is added to validate the window calculation against a
fixed reference time.
Fixes #
How Has This Been Tested?
Added a unit test for
get_windowusing a fixed reference time.Verified locally by running:
uv run pytest src/quartz_api/internal/backends/test_utils.pyIf your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: